Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compiler error 0034 to use new format. #36136

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Update compiler error 0034 to use new format. #36136

merged 1 commit into from
Aug 31, 2016

Conversation

athulappadan
Copy link
Contributor

Part of #35233
Addresses #35205

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2016

📌 Commit fb65fe9 has been approved by jonathandturner

@athulappadan
Copy link
Contributor Author

Why one check failed.?

r? @jonathandturner @GuillaumeGomez

@sophiajt
Copy link
Contributor

@athulappadan - the tools team is fixing an issue in travis, so it's not with your PR

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36136 - athulappadan:E0034, r=jonathandturner
a1a3474 
Update compiler error 0034 to use new format.

Part of rust-lang#35233
Addresses rust-lang#35205

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36136 - athulappadan:E0034, r=jonathandturner
e732d87 
Update compiler error 0034 to use new format.

Part of rust-lang#35233
Addresses rust-lang#35205

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36136 - athulappadan:E0034, r=jonathandturner
5eb53d9 
Update compiler error 0034 to use new format.

Part of rust-lang#35233
Addresses rust-lang#35205

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36136 - athulappadan:E0034, r=jonathandturner
d18f148 
Update compiler error 0034 to use new format.

Part of rust-lang#35233
Addresses rust-lang#35205

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Merged
bors added a commit that referenced this pull request Aug 31, 2016
@bors
Auto merge of #36166 - jonathandturner:rollup, r=jonathandturner
7a187c3 
Rollup of 16 pull requests

- Successful merges: #35758, #35926, #36050, #36079, #36085, #36089, #36101, #36130, #36134, #36135, #36136, #36140, #36141, #36147, #36148, #36165
- Failed merges:
@bors bors merged commit fb65fe9 into rust-lang:master Aug 31, 2016
@athulappadan athulappadan deleted the E0034 branch September 7, 2016 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@athulappadan @rust-highfive @sophiajt @bors