Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Err codes #36141

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Err codes #36141

merged 2 commits into from
Aug 31, 2016

Conversation

GuillaumeGomez
Copy link
Member

parir
parir reviewed Aug 30, 2016
View reviewed changes
src/librustc_resolve/diagnostics.rs
}
```

To fix this error, just change the binding's name in order to avid shadowing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/avid/avoid/

@sophiajt
Copy link
Contributor

Can't tell for sure, but this might be a legit error:

thread 'main' panicked at '
failures:

---- [run-pass] run-pass/issue-36023.rs stdout ----

error: test run failed!
status: signal: 11

Does this reproduce locally for you @GuillaumeGomez?

@sophiajt
Copy link
Contributor

Looks like maybe not, I just saw the same issue on someone else's PR, too...

@sophiajt
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2016

📌 Commit 37bf449 has been approved by jonathandturner

@sophiajt
Copy link
Contributor

@bors rollup

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36141 - GuillaumeGomez:err_codes, r=jonatha…
251697b 
…ndturner

Err codes

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36141 - GuillaumeGomez:err_codes, r=jonatha…
3a6acda 
…ndturner

Err codes

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36141 - GuillaumeGomez:err_codes, r=jonatha…
5123b38 
…ndturner

Err codes

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36141 - GuillaumeGomez:err_codes, r=jonatha…
93c5d6c 
…ndturner

Err codes

r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Merged
bors added a commit that referenced this pull request Aug 31, 2016
@bors
Auto merge of #36166 - jonathandturner:rollup, r=jonathandturner
7a187c3 
Rollup of 16 pull requests

- Successful merges: #35758, #35926, #36050, #36079, #36085, #36089, #36101, #36130, #36134, #36135, #36136, #36140, #36141, #36147, #36148, #36165
- Failed merges:
@bors bors merged commit 37bf449 into rust-lang:master Aug 31, 2016
@GuillaumeGomez GuillaumeGomez deleted the err_codes branch September 1, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @sophiajt @bors @parir