Improve documention troubleshooting missing linker. Fix #32208. #36672

pmatos · 2016-09-23T15:42:40Z

@steveklabnik is this in the direction on how you want to see #32208 fixed?

rust-highfive · 2016-09-23T15:42:54Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

steveklabnik · 2016-09-23T15:48:02Z

@pmatos yes, looks great to me, thank you!

@bors: r+ rollup

bors · 2016-09-23T15:48:03Z

📌 Commit ec2f778 has been approved by steveklabnik

retep998 · 2016-09-23T19:11:10Z

src/doc/book/getting-started.md

+Linux-based systems, Rust will attempt to call `cc` for linking. On
+`windows-msvc` (Rust built on windows with Microsoft Visual Studio),
+this depends on having Microsoft Visual Studio installed with its
+tools in `%PATH%`, namely `linker.exe`. However, if you have your


link.exe. Also it doesn't need to be in PATH because rustc can find msvc itself.

Probably would be better to simply say you need to have the "Visual C++ Build Tools" installed, with possibly a link to http://landinghub.visualstudio.com/visual-cpp-build-tools

steveklabnik · 2016-09-23T19:14:27Z

@bors: r-

gah, read that one wrong, sorry

sfackler · 2016-09-23T19:14:34Z

@bors r-

Pending @retep998's link.exe comment.

pmatos · 2016-09-24T08:09:29Z

@retep998 thanks, preparing new pull request.

pmatos · 2016-09-24T08:19:17Z

@retep998 I tried with the new pull request to take your comments into consideration but if there's something else that can be improved, please let me know.

steveklabnik

One tiny nit, and then if @retep998 is happy, I'm happy.

steveklabnik · 2016-09-26T19:34:53Z

src/doc/book/getting-started.md

-general discussion [the #rust IRC channel on irc.mozilla.org][irc], which we
+installed. Doing so will depend on your specific system. For
+Linux-based systems, Rust will attempt to call `cc` for linking. On
+`windows-msvc` (Rust built on windows with Microsoft Visual Studio),


Windows, not windows.

retep998 · 2016-09-26T20:34:01Z

src/doc/book/getting-started.md

+installed. Doing so will depend on your specific system. For
+Linux-based systems, Rust will attempt to call `cc` for linking. On
+`windows-msvc` (Rust built on windows with Microsoft Visual Studio),
+this depends on having [Microsoft Visual Build Tools][msvbt]


Microsoft Visual _C++_ Build Tools

pmatos · 2016-09-27T06:50:44Z

@steveklabnik Done. @retep998 Done.
The last two commits should have fixed the concerns you had. Thanks for the help on getting this pull request complete.

steveklabnik · 2016-09-27T14:06:55Z

Great! Thanks so much for your patience here too.

One last question before I merge: it seems that the commit authorship is different than your github account. Is that what you intended? If so, it's fine, but otherwise, you might want to fix that before we merge 😄

pmatos · 2016-09-27T18:11:35Z

You're right. Let me fix authorship. Sorry for this.

steveklabnik · 2016-09-27T18:19:19Z

It's no worries! :)

pmatos · 2016-09-27T18:43:31Z

@steveklabnik I have rewritten history on my end in order to change commit authorship which worked but now github falsely shows branch conflicts. Would you be ok with accepting this or do you want me to restart a brand new pull request on this?

steveklabnik · 2016-09-27T19:26:51Z

Re-writing the history is totally fine :)

steveklabnik · 2016-09-27T19:27:18Z

(the message in the bot is meant to be talking about during review, not administrative stuff like this at the end 😄 )

pmatos · 2016-09-27T19:34:00Z

Great! So we are good to go. Happy to contribute. Anything else you have in mind that I could tackle next?

On 27 September 2016 21:27:49 CEST, Steve Klabnik notifications@github.com wrote:

(the message in the bot is meant to be talking about during review,
not administrative stuff like this at the end 😄 )

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#36672 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

steveklabnik · 2016-09-27T19:44:21Z

(You have to force push, it didn't actually update the PR)

Thanks! We have the A-docs tag for doc stuff, and not all of them are super difficult: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AA-docs

https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AA-docs+label%3AE-easy are specifically the ones tagged easy. Lots to do!

steveklabnik · 2016-09-27T19:44:52Z

Oh, it's not that you didn't force push, it's that when you did, it somehow got on the wrong base. Try to rebase things and force push again.

pmatos · 2016-09-27T20:06:52Z

@steveklabnik Is this ok now? I have rebased LinkiTools/rust and pushed (no need to force now).

steveklabnik · 2016-09-27T20:13:45Z

Hm, it still says 250+ commits 👀

If you want some help, I can do it: I'd just need you to follow the second half here: https://github.com/blog/2247-improving-collaboration-with-forks

pmatos · 2016-09-27T20:18:57Z

@steveklabnik The checkbox to allow edits from maintainers is enabled. Thanks for your help. I have no idea at the moment what kind of weird games git/github is playing with me.

steveklabnik · 2016-09-27T20:50:45Z

Whew! @pmatos , I don't know what happened, but something was very wrong. Trying to deal with this made my git go a bit... intense.

However, I managed to make it work. Here's what I did:

git rebase -i to squash the four commits into one.
git remote add upstream https://github.com/rust-lang/rust/
git fetch upstream
git reset --hard upstream/master
git cherry-pick cb3b03c
git push origin master -f

Specifically step 4 says "make this branch equal to master" and then the cherry-pick lets you apply a random commit on top. Whew!

Can you verify that this commit is what you wanted to send in? It looks okay with me, but since I just re-wrote your history, it's important that you read it before we merge, since it's in your name 😄

pmatos · 2016-09-27T20:56:43Z

@steveklabnik many thanks for your time. roll it up. :) see in the next pull request.

steveklabnik · 2016-09-27T20:58:06Z

Great! I think one of the problems might have been that it was on master instead of a branch, so maybe make a branch per PR next time? 😄

steveklabnik · 2016-09-27T20:58:18Z

@bors: r+ rollup

bors · 2016-09-27T20:58:19Z

📌 Commit cb3b03c has been approved by steveklabnik

pmatos · 2016-09-28T06:39:42Z

@steveklabnik I will use a branch per PR next time. Thanks.

@steveklabnik

Improve documention troubleshooting missing linker. Fix rust-lang#32208. @steveklabnik is this in the direction on how you want to see rust-lang#32208 fixed?

Rollup of 11 pull requests - Successful merges: #36376, #36672, #36740, #36757, #36765, #36769, #36782, #36783, #36784, #36795, #36796 - Failed merges:

rust-highfive assigned Manishearth Sep 23, 2016

retep998 reviewed Sep 23, 2016

View reviewed changes

steveklabnik suggested changes Sep 26, 2016

View reviewed changes

retep998 reviewed Sep 26, 2016

View reviewed changes

steveklabnik approved these changes Sep 27, 2016

View reviewed changes

pmatos force-pushed the master branch from a1670d0 to 27f94aa Compare September 27, 2016 18:41

Improve documention troubleshooting missing linker. Fix rust-lang#32208.

cb3b03c

steveklabnik force-pushed the master branch from 72355ad to cb3b03c Compare September 27, 2016 20:47

sophiajt mentioned this pull request Sep 28, 2016

Rollup of 11 pull requests #36805

Merged

bors added a commit that referenced this pull request Sep 28, 2016

Auto merge of #36805 - jonathandturner:rollup, r=jonathandturner

86affcd

Rollup of 11 pull requests - Successful merges: #36376, #36672, #36740, #36757, #36765, #36769, #36782, #36783, #36784, #36795, #36796 - Failed merges:

bors merged commit cb3b03c into rust-lang:master Sep 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve documention troubleshooting missing linker. Fix #32208. #36672

Improve documention troubleshooting missing linker. Fix #32208. #36672

pmatos commented Sep 23, 2016

rust-highfive commented Sep 23, 2016

steveklabnik commented Sep 23, 2016

bors commented Sep 23, 2016

retep998 Sep 23, 2016 •

edited

Loading

steveklabnik commented Sep 23, 2016

sfackler commented Sep 23, 2016

pmatos commented Sep 24, 2016

pmatos commented Sep 24, 2016

steveklabnik left a comment

steveklabnik Sep 26, 2016

retep998 Sep 26, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016 •

edited

Loading

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

bors commented Sep 27, 2016

pmatos commented Sep 28, 2016

Improve documention troubleshooting missing linker. Fix #32208. #36672

Improve documention troubleshooting missing linker. Fix #32208. #36672

Conversation

pmatos commented Sep 23, 2016

rust-highfive commented Sep 23, 2016

steveklabnik commented Sep 23, 2016

bors commented Sep 23, 2016

retep998 Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

steveklabnik commented Sep 23, 2016

sfackler commented Sep 23, 2016

pmatos commented Sep 24, 2016

pmatos commented Sep 24, 2016

steveklabnik left a comment

Choose a reason for hiding this comment

steveklabnik Sep 26, 2016

Choose a reason for hiding this comment

retep998 Sep 26, 2016

Choose a reason for hiding this comment

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016 • edited Loading

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

pmatos commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

bors commented Sep 27, 2016

pmatos commented Sep 28, 2016

retep998 Sep 23, 2016 •

edited

Loading

pmatos commented Sep 27, 2016 •

edited

Loading