update mips64* data-layout #36796
Merged
update mips64* data-layout #36796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hmm, I probably tested this target against our LLVM (3.9) and then against Ubuntu's LLVM (3.8) but didn't realize. We should change this to work with our LLVM. @TimNN, did you test against our LLVM? |
|
Yes, I tested with |
|
📌 Commit 3a27647 has been approved by |
|
@bors rollup |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 28, 2016
update mips64* data-layout I tried to compile some (`#![no_core]`) code for the `mips64` targets on the latest nightly and got ICE's about mismatched data layouts. I updated the data layouts to match the listed llvm defaults. cc @japaric Funnily enough, this seems to be the exact reverse of what @japaric did in 2222d43 as part of rust-lang#36024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to compile some (
#![no_core]) code for themips64targets on the latest nightly and got ICE's about mismatched data layouts. I updated the data layouts to match the listed llvm defaults.cc @japaric
Funnily enough, this seems to be the exact reverse of what @japaric did in 2222d43 as part of #36024.