Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in char::to_uppercase documentation #40833

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

Wallacoloo
Copy link
Contributor

Original documentation appears to have been copied from char::to_lowercase in a manner that made it imply that char::to_uppercase actually mapped unicode characters to their lowercase equivalent.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

whoops, thank you!

@bors
Copy link
Contributor

bors commented Mar 27, 2017

📌 Commit 188299e has been approved by steveklabnik

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 27, 2017
…=steveklabnik

Fix typo in char::to_uppercase documentation

Original documentation appears to have been copied from `char::to_lowercase` in a manner that made it imply that `char::to_uppercase` actually mapped unicode characters to their **lowercase** equivalent.
bors added a commit that referenced this pull request Mar 27, 2017
bors added a commit that referenced this pull request Mar 28, 2017
@bors bors merged commit 188299e into rust-lang:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants