Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some docs for VecDeque #40949

Merged
merged 2 commits into from Apr 5, 2017
Merged

Improve some docs for VecDeque #40949

merged 2 commits into from Apr 5, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2017

@@ -1073,7 +1073,7 @@ impl<T> VecDeque<T> {
}
}

/// Inserts an element first in the sequence.
/// Prepends an element to the front of the `VecDeque`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preprend means inserting to the front, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For push_back we have this sentence: Appends an element to the back of the VecDeque.

I just mirrored that wording for push_front. :) Do you have a better suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "prepends an element to the VecDeque".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@frewsxcv frewsxcv added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Apr 1, 2017
@frewsxcv
Copy link
Member

frewsxcv commented Apr 1, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit 1e2a61d has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017
@GuillaumeGomez
Copy link
Member

@rfcbot reviewed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017
bors added a commit that referenced this pull request Apr 5, 2017
@bors bors merged commit 1e2a61d into rust-lang:master Apr 5, 2017
@ghost ghost deleted the fix-vecdeque-docs branch April 5, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants