Rollup of 12 pull requests #41041
Closed
Rollup of 12 pull requests #41041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change `utf8` variable names to `non_ascii` to be more clear, since ASCII and UTF-8 are compatible. * Fix `EscapeDefault` struct description to follow the typical iterator method format with a link to the generating function. * Add more `escape_default` examples to cover every case mentioned in the function description itself.
This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closes rust-lang#37499
This reverts commit 2cf686f (rust-lang#40842) RawFd is a type alias for c_int, which is itself a type alias for i32. As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds them for i32. As a result, the reverted commit makes this valid: ``` use std::os::unix::io::AsRawFd; fn arf<T: AsRawFd>(_: T) {} fn main() { arf(32i32) } ``` Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both those traits that their methods return a valid RawFd. r? @aturon cc @Mic92 @kamalmarhubi
…ncy, r=steveklabnik Fix mutex's docs inconsistency Fixes rust-lang#40176. r? @steveklabnik cc @rust-lang/docs
…ystem, r=aturon rustc: Stabilize the `#![windows_subsystem]` attribute This commit stabilizes the `#![windows_subsystem]` attribute which is a conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This is useful for creating applications as well as console programs. Closes rust-lang#37499
… r=alexcrichton Add a note about overflow for fetch_add/fetch_sub Fixes rust-lang#40916 Fixes rust-lang#34618 r? @steveklabnik
Improve some docs for VecDeque r? @GuillaumeGomez
…steveklabnik Updating the description for BarrierWaitResult rust-lang#29377 Referencing `Barrier`, removing reference to `is_leader`.
API Docs: ascii Add/update docs for the `ascii` module per rust-lang#29341. r? @steveklabnik
…xcrichton Added links to from_utf8 methods in Utf8Error Referencing rust-lang#29375. Linked the `from_utf8` methods for both `String` and `str` in the description. Also linked the `u8` to its documentation
…teveklabnik Added links to types in from_utf8 description References rust-lang#29375. Link to types mentioned in the documentation for `from_utf8` (`str`, `&[u8`], etc). Paragraphs were reformatted to keep any one line from being excessively long, but are otherwise unchanged.
…teveklabnik Improve option API docs Associated Issue: rust-lang#29366 Improve `option` API docs for * `IntoIter` struct * `Iter` struct * `IterMut` struct r? @steveklabnik
Improve documentation for `std::fs::DirBuilder`
std::thread docs: fix link to current()
…aturon Revert "Implement AsRawFd/IntoRawFd for RawFd" This reverts commit 2cf686f (rust-lang#40842) RawFd is a type alias for c_int, which is itself a type alias for i32. As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds them for i32. As a result, the reverted commit makes this valid: ``` use std::os::unix::io::AsRawFd; fn arf<T: AsRawFd>(_: T) {} fn main() { arf(32i32) } ``` Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both those traits that their methods return a valid RawFd. r? @aturon cc @Mic92 @kamalmarhubi
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=7 |
|
📌 Commit 57d7787 has been approved by |
|
⌛ Testing commit 57d7787 with merge cf3abc3... |
|
💔 Test failed - status-travis |
|
@bors r=frewsxcv |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 57d7787 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#![windows_subsystem]attribute #40870, Add a note about overflow for fetch_add/fetch_sub #40927, Improve some docs for VecDeque #40949, Updating the description for BarrierWaitResult #29377 #40977, API Docs: ascii #40988, Added links to from_utf8 methods in Utf8Error #40992, Added links to types in from_utf8 description #40997, Improve option API docs #40999, Improve documentation forstd::fs::DirBuilder#41007, std::thread docs: fix link to current() #41014, Revert "Implement AsRawFd/IntoRawFd for RawFd" #41035