Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #41040

Closed
wants to merge 33 commits into from
Closed

Rollup of 13 pull requests #41040

wants to merge 33 commits into from

Commits on Mar 30, 2017

  1. Add a note about overflow for fetch_add/fetch_sub

    Stjepan Glavina committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    3fa28cc View commit details
    Browse the repository at this point in the history
  2. More consistent wording

    Stjepan Glavina committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    2946c41 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. Improve some docs for VecDeque

    Stjepan Glavina committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    d7b3f05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44d8b23 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. Change wording for push_front

    Stjepan Glavina committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    1e2a61d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5198072 View commit details
    Browse the repository at this point in the history
  3. Clean up std::ascii sub-level docs.

    * Change `utf8` variable names to `non_ascii` to be more clear, since
    ASCII and UTF-8 are compatible.
    
    * Fix `EscapeDefault` struct description to follow the typical iterator
    method format with a link to the generating function.
    
    * Add more `escape_default` examples to cover every case mentioned in
    the function description itself.
    Eugene Bulkin committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    d8fb322 View commit details
    Browse the repository at this point in the history
  4. Add more std::ascii module-level docs.

    Eugene Bulkin committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    a5d775d View commit details
    Browse the repository at this point in the history
  5. rustc: Stabilize the #![windows_subsystem] attribute

    This commit stabilizes the `#![windows_subsystem]` attribute which is a
    conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
    is useful for creating applications as well as console programs.
    
    Closes rust-lang#37499
    alexcrichton committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    34cf288 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    364241c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    128a313 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    029ace4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c414628 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2017

  1. Configuration menu
    Copy the full SHA
    4c9f8ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff4febf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    509ef4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    255d919 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. Revert "Implement AsRawFd/IntoRawFd for RawFd"

    This reverts commit 2cf686f (rust-lang#40842)
    
    RawFd is a type alias for c_int, which is itself a type alias for i32.
    As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds
    them for i32.
    
    As a result, the reverted commit makes this valid:
    
    ```
    use std::os::unix::io::AsRawFd;
    
    fn arf<T: AsRawFd>(_: T) {}
    
    fn main() {
        arf(32i32)
    }
    ```
    
    Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both
    those traits that their methods return a valid RawFd.
    
    r? @aturon
    cc @Mic92 @kamalmarhubi
    codyps committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    9c1b7ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f74ca38 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7c2160 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#40608 - GuillaumeGomez:mutex-doc-inconsiste…

    …ncy, r=steveklabnik
    
    Fix mutex's docs inconsistency
    
    Fixes rust-lang#40176.
    
    r? @steveklabnik
    cc @rust-lang/docs
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    930c997 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…

    …ystem, r=aturon
    
    rustc: Stabilize the `#![windows_subsystem]` attribute
    
    This commit stabilizes the `#![windows_subsystem]` attribute which is a
    conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
    is useful for creating applications as well as console programs.
    
    Closes rust-lang#37499
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    9fd0a18 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#40927 - stjepang:docs-atomic-overflow-note,…

    … r=alexcrichton
    
    Add a note about overflow for fetch_add/fetch_sub
    
    Fixes rust-lang#40916
    Fixes rust-lang#34618
    
    r? @steveklabnik
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    3682a33 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#40949 - stjepang:fix-vecdeque-docs, r=frewsxcv

    Improve some docs for VecDeque
    
    r? @GuillaumeGomez
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    545a89e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#40977 - projektir:BarrierWaitResult_doc, r=…

    …steveklabnik
    
    Updating the description for BarrierWaitResult rust-lang#29377
    
    Referencing `Barrier`, removing reference to `is_leader`.
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    f0cbfaa View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#40988 - eugene-bulkin:ascii-docs, r=frewsxcv

    API Docs: ascii
    
    Add/update docs for the `ascii` module per rust-lang#29341.
    
    r? @steveklabnik
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    139e346 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#40992 - donniebishop:utf8err_linking, r=ale…

    …xcrichton
    
    Added links to from_utf8 methods in Utf8Error
    
    Referencing  rust-lang#29375. Linked the `from_utf8` methods for both `String` and `str` in the description. Also linked the `u8` to its documentation
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    fd37622 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#40997 - donniebishop:from_utf8_linking, r=s…

    …teveklabnik
    
    Added links to types in from_utf8 description
    
    References rust-lang#29375. Link to types mentioned in the documentation for `from_utf8` (`str`, `&[u8`], etc). Paragraphs were reformatted to keep any one line from being excessively long, but are otherwise unchanged.
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    2a01b3e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#40999 - irfanhudda:improve-option-docs, r=s…

    …teveklabnik
    
    Improve option API docs
    
    Associated Issue: rust-lang#29366
    
    Improve `option` API docs for
    * `IntoIter` struct
    * `Iter` struct
    * `IterMut` struct
    
    r? @steveklabnik
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    ec8f1df View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#41007 - pgerber:dir_builder, r=frewsxcv

    Improve documentation for `std::fs::DirBuilder`
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    826ec40 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#41014 - SimonSapin:patch-6, r=frewsxcv

    std::thread docs: fix link to current()
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    f22cc07 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#41019 - mandeep:fix-vec-swapremove-docs, r=…

    …BurntSushi
    
    Fixed typo in doc comments for swap_remove
    
    While reading the Vec docs, I came across the docs for swap_remove. I believe there is a typo in the comment and ```return``` should be ```returns```. This PR fixes this issue.
    
    I also feel that the entire doc comment is a bit of a run-on and could be changed to something along the lines of ```Removes an element from anywhere in the vector and returns it. The vector is mutated and the removed element is replaced by the last element of the vector. ```
    
    Thoughts?
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    c303fe0 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#41035 - jmesmon:revert-bad-raw-fd-impls, r=…

    …aturon
    
    Revert "Implement AsRawFd/IntoRawFd for RawFd"
    
    This reverts commit 2cf686f (rust-lang#40842)
    
    RawFd is a type alias for c_int, which is itself a type alias for i32.
    As a result, adding AsRawFd and IntoRawFd impls for RawFd actually adds
    them for i32.
    
    As a result, the reverted commit makes this valid:
    
    ```
    use std::os::unix::io::AsRawFd;
    
    fn arf<T: AsRawFd>(_: T) {}
    
    fn main() {
        arf(32i32)
    }
    ```
    
    Implimenting AsRawFd and IntoRawFd for i32 breaks the promises of both
    those traits that their methods return a valid RawFd.
    
    r? @aturon
    cc @Mic92 @kamalmarhubi
    frewsxcv committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    97ce03c View commit details
    Browse the repository at this point in the history