Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override ToOwned::clone_into for Path and OsStr #41390

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

scottmcm
Copy link
Member

The only non-overridden one remaining is the CStr impl, which cannot
be optimized as doing so would break CString's second invariant.

Follow-up to 7ec27ae (PR #41009).

r? @alexcrichton

The only non-overridden one remaining is the CStr impl, which cannot
be optimized as doing so would break CString's second invariant.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs
Copy link
Member

aidanhs commented Apr 19, 2017

Thanks for the PR! We'll make sure @alexcrichton or another reviewer gets to your PR soon.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks @scottmcm!

@bors
Copy link
Contributor

bors commented Apr 19, 2017

📌 Commit 295bcdb has been approved by alexcrichton

@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 19, 2017
…crichton

Override ToOwned::clone_into for Path and OsStr

The only non-overridden one remaining is the CStr impl, which cannot
be optimized as doing so would break CString's second invariant.

Follow-up to 7ec27ae (PR rust-lang#41009).

r? @alexcrichton
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 20, 2017
…crichton

Override ToOwned::clone_into for Path and OsStr

The only non-overridden one remaining is the CStr impl, which cannot
be optimized as doing so would break CString's second invariant.

Follow-up to 7ec27ae (PR rust-lang#41009).

r? @alexcrichton
bors added a commit that referenced this pull request Apr 20, 2017
Rollup of 5 pull requests

- Successful merges: #41214, #41369, #41377, #41378, #41390
- Failed merges:
@bors bors merged commit 295bcdb into rust-lang:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants