Fix ICE building gluon_vm #41377
Merged
Fix ICE building gluon_vm #41377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Apr 18, 2017
| }); | ||
| .map(|InferOk { obligations, .. }| { | ||
| fulfillment_cx.borrow_mut() | ||
| .register_predicate_obligations(infcx, obligations); |
There was a problem hiding this comment.
IMO this should be using the equivalent inh instead... or not construct an Inherited at all.
eddyb
approved these changes
Apr 18, 2017
|
Wait, #41325 isn't merged yet, that explains why that code looks old. What are the intended interactions between the two PRSs? |
|
Hmm, doesn't seem that they overlap much, but I can try to merge on top of that one. |
|
#41325 merged, please rebase. |
cc rust-lang#32730 -- I left exactly one instance where I wasn't sure of the right behavior.
nikomatsakis
force-pushed
the
issue-41298-ICE-inference
branch
from
435b789
to
93e1097
Compare
|
@bors r=eddyb |
|
📌 Commit 93e1097 has been approved by |
aidanhs
added
the
S-waiting-on-bors
|
@bors retry Already merged |
|
@bors r- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was due to various places we were failing to propagate obligations. I think I got them mostly correct, but I didn't get around to writing test cases for each case.
r? @eddyb or @arielb1