Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc tests for trim_right_matches #46128

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Fix doc tests for trim_right_matches #46128

merged 2 commits into from
Nov 21, 2017

Conversation

Arzte
Copy link
Contributor

@Arzte Arzte commented Nov 20, 2017

First pr, but isn't anything big so hopefully it should all be good.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

dtolnay
dtolnay reviewed Nov 20, 2017
View reviewed changes
src/liballoc/str.rs Outdated
@@ -1734,7 +1734,7 @@ impl str {
/// A more complex pattern, using a closure:
///
/// ```
/// assert_eq!("1fooX".trim_left_matches(|c| c == '1' || c == 'X'), "fooX");
/// assert_eq!("1fooX".trim_right_matches(|c| c == '1' || c == 'X'), "fooX");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trimming from the right, the result would no longer be "fooX". I think it would be "1foo". https://play.rust-lang.org/?gist=433e02bea040f9f2364621f3cf0830a4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I see it, nice response time tho.

@dtolnay
Copy link
Member

dtolnay commented Nov 20, 2017

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2017

📌 Commit f69d4d4 has been approved by dtolnay

@dtolnay
Copy link
Member

dtolnay commented Nov 20, 2017

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Nov 20, 2017
@kennytm
Rollup merge of rust-lang#46128 - Coding-Doctors:patch-1, r=dtolnay
079a6e4 
Fix doc tests for trim_right_matches

First pr, but isn't anything big so hopefully it should all be good.
@kennytm kennytm mentioned this pull request Nov 20, 2017
Merged
@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 20, 2017
bors added a commit that referenced this pull request Nov 20, 2017
@bors
Auto merge of #46130 - kennytm:rollup, r=kennytm
1e44fee 
Rollup of 9 pull requests

- Successful merges: #46082, #46088, #46092, #46107, #46119, #46121, #46122, #46124, #46128
- Failed merges:
@bors bors merged commit f69d4d4 into rust-lang:master Nov 21, 2017
@Arzte Arzte deleted the patch-1 branch November 21, 2017 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arzte @rust-highfive @dtolnay @bors @kennytm