Rollup of 9 pull requests #46130
Merged
Rollup of 9 pull requests #46130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have this as a Unix-only API since it seems like Windows doesn't have a similar API.
This makes it more robust when assertions are disabled, crashing instead of causing UB. Also introduces a tidy check to enforce this rule, which in turn necessitated making tidy run on src/rustllvm. Fixes rust-lang#44020
impl From for Mutex and RwLock I felt that these implementations were missing, because doing `x.into()` works for other smart containers (such as `RefCell`), and in general I would say that the conversion makes sense.
add doc for doing `Read` from `&str` This information can be found on [stackoverflow](https://stackoverflow.com/questions/32674905/pass-string-to-function-taking-read-trait) but I think it would be beneficial if it was documented in the `Read` trait itself. I had an *extremely* hard time finding this information, and "mocking" a reader with a string is an EXTREMELY common thing (I believe).
Add process::parent_id I have this as a Unix-only API since it seems like Windows doesn't have a similar API. r? @alexcrichton
Fixes spelling error in COMPILER_TESTS.md Fixes a small spelling mistake :P
Fix typo in MIR "cannot move out of borrowed content" I believe this all we need to change (rust-lang#46018). Anyway, do let me know if there is anything else that needs to changed as well!
Print the address of the pointed value in Pointer impl for Rc and Arc Fixes rust-lang#35384
Fix some docs summary nits
[rustllvm] Use report_fatal_error over llvm_unreachable This makes it more robust when assertions are disabled, crashing instead of causing UB. Also introduces a tidy check to enforce this rule, which in turn necessitated making tidy run on `src/rustllvm`. Fixes rust-lang#44020
Fix doc tests for trim_right_matches First pr, but isn't anything big so hopefully it should all be good.
|
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=9 Huh I thought Homu will repopulate the previous rollup. |
|
📌 Commit 079a6e4 has been approved by |
kennytm
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 20, 2017
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readfrom&str#46088, Add process::parent_id #46092, Fixes spelling error in COMPILER_TESTS.md #46107, Fix typo in MIR "cannot move out of borrowed content" #46119, Print the address of the pointed value in Pointer impl for Rc and Arc #46121, Fix some docs summary nits #46122, [rustllvm] Use report_fatal_error over llvm_unreachable #46124, Fix doc tests for trim_right_matches #46128