-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 20 pull requests #49317
Rollup of 20 pull requests #49317
Commits on Mar 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 683ad94 - Browse repository at this point
Copy the full SHA 683ad94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b43dcb - Browse repository at this point
Copy the full SHA 3b43dcbView commit details -
Always print
aborting due to n previous error(s)
and only print it ……once for multi-threaded code
Configuration menu - View commit details
-
Copy full SHA for 910bf84 - Browse repository at this point
Copy the full SHA 910bf84View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1d872b - Browse repository at this point
Copy the full SHA b1d872bView commit details
Commits on Mar 17, 2018
-
rustbuild: Tweak where timing information goes
This commit tweaks where timing and step information is printed out as part of the build, ensuring that we do it as close to the location where work happens as possible. In rustbuild various functions may perform long blocking work as dependencies are assembled, so if we print out timing information early on we may accidentally time more than just the step we were intending to time!
Configuration menu - View commit details
-
Copy full SHA for 6fd4d67 - Browse repository at this point
Copy the full SHA 6fd4d67View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57ea56 - Browse repository at this point
Copy the full SHA b57ea56View commit details -
Add a -Z flag for LLVM align attributes on arguments
LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with. For example, this makes `swap::<u64x8>` be 8x `vmovaps ymm` instead of 16x `vmovups xmm`, on my cpu.
Configuration menu - View commit details
-
Copy full SHA for b498192 - Browse repository at this point
Copy the full SHA b498192View commit details
Commits on Mar 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9a44448 - Browse repository at this point
Copy the full SHA 9a44448View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca2604 - Browse repository at this point
Copy the full SHA cca2604View commit details
Commits on Mar 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c5c650d - Browse repository at this point
Copy the full SHA c5c650dView commit details -
This stabilizes `main` with non-() return types; see rust-lang#48453.
Configuration menu - View commit details
-
Copy full SHA for 97b3bf9 - Browse repository at this point
Copy the full SHA 97b3bf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a55e7 - Browse repository at this point
Copy the full SHA e5a55e7View commit details
Commits on Mar 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for be29e52 - Browse repository at this point
Copy the full SHA be29e52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ccf3ff - Browse repository at this point
Copy the full SHA 5ccf3ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eff4d9 - Browse repository at this point
Copy the full SHA 4eff4d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef6948 - Browse repository at this point
Copy the full SHA 1ef6948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe791c - Browse repository at this point
Copy the full SHA 0fe791cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5e991e - Browse repository at this point
Copy the full SHA b5e991eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7bec01 - Browse repository at this point
Copy the full SHA b7bec01View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4457b3 - Browse repository at this point
Copy the full SHA e4457b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a334c9 - Browse repository at this point
Copy the full SHA 8a334c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1197f9a - Browse repository at this point
Copy the full SHA 1197f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0027e98 - Browse repository at this point
Copy the full SHA 0027e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca8eeb - Browse repository at this point
Copy the full SHA bca8eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for a347bb3 - Browse repository at this point
Copy the full SHA a347bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf41fde - Browse repository at this point
Copy the full SHA cf41fdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 116dd62 - Browse repository at this point
Copy the full SHA 116dd62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53405ec - Browse repository at this point
Copy the full SHA 53405ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72334fe - Browse repository at this point
Copy the full SHA 72334feView commit details -
Make resuming generators unsafe instead of the creation of immovable …
…generators. Fixes rust-lang#47787
Configuration menu - View commit details
-
Copy full SHA for 57896ab - Browse repository at this point
Copy the full SHA 57896abView commit details
Commits on Mar 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ac33ec7 - Browse repository at this point
Copy the full SHA ac33ec7View commit details -
Revert "Stabilize termination_trait in 1.25, not 1.26"
This reverts commit e5a55e7.
Configuration menu - View commit details
-
Copy full SHA for 1937661 - Browse repository at this point
Copy the full SHA 1937661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94bdeb6 - Browse repository at this point
Copy the full SHA 94bdeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cdc7af - Browse repository at this point
Copy the full SHA 2cdc7afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06f8103 - Browse repository at this point
Copy the full SHA 06f8103View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75dcc61 - Browse repository at this point
Copy the full SHA 75dcc61View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6934c9 - Browse repository at this point
Copy the full SHA b6934c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 178652a - Browse repository at this point
Copy the full SHA 178652aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1392179 - Browse repository at this point
Copy the full SHA 1392179View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6a35aa - Browse repository at this point
Copy the full SHA f6a35aaView commit details
Commits on Mar 22, 2018
-
Fixed clockwise/counter-clockwise in atan2 documentation in f32 and f64
and included that it returns radians
Configuration menu - View commit details
-
Copy full SHA for c116b0e - Browse repository at this point
Copy the full SHA c116b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b13d95 - Browse repository at this point
Copy the full SHA 2b13d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for ecafa7b - Browse repository at this point
Copy the full SHA ecafa7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a3bf2 - Browse repository at this point
Copy the full SHA a1a3bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88268d7 - Browse repository at this point
Copy the full SHA 88268d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9839e5f - Browse repository at this point
Copy the full SHA 9839e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0118a65 - Browse repository at this point
Copy the full SHA 0118a65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fa14e4 - Browse repository at this point
Copy the full SHA 9fa14e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d87b403 - Browse repository at this point
Copy the full SHA d87b403View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b0e9f5 - Browse repository at this point
Copy the full SHA 1b0e9f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73fa6d5 - Browse repository at this point
Copy the full SHA 73fa6d5View commit details
Commits on Mar 23, 2018
-
Allow installing rustfmt without config.extended
This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
Configuration menu - View commit details
-
Copy full SHA for 86f7d89 - Browse repository at this point
Copy the full SHA 86f7d89View commit details -
ci: Don't use Travis caches for docker images
This commit moves away from caching on Travis to our own caching on S3 for caching docker layers between builds. Unfortunately the Travis caches have over time had a few critical pain points: * Caches are only updated for successful builds, meaning that if a build times out or fails in a different location the sucessfully-created docker images isn't always cached. While this makes sense as a general rule of caches it hurts our use cases. * Caches are per-branch and builder which means that we don't have a separate cache on each release channel. All our merges go through the `auto` branch which means that they're all sharing the same cache, even those for merging to master/beta. This means that PRs which switch between master/beta will keep rebuilting and having cache misses. * Caches have historically been invaliated somewhat regularly a little more aggressively than we'd want (I think). * We don't always need to update the contents of the cache if the Docker image didn't change at all, and saving off the docker layers can sometimes be quite expensive. For all these reasons this commit drops the usage of Travis's built-in caching support. Instead our own caching is used by storing blobs to S3. Normally this would be a very risky endeavour but we're basically priming a cache for a cache (docker) so if we get this wrong the failure mode is longer builds, not stale caches. We'll notice that pretty quickly and hopefully fix it! The logic here is inserted directly into the `src/ci/docker/run.sh` script to download an image based on a shasum of the `Dockerfile` and other assorted files. This blob, if found, is loaded into docker and we record what layers were inserted. After docker finishes the build (hopefully quickly with lots of cache hits) we then see the sha of the final image. If it's one of the layers we loaded then there's no need to update the cache. Otherwise we upload our layers to the global cache, possibly overwriting what we previously just downloaded. This is hopefully a step towards mitigating rust-lang#49278 although it doesn't completely fix it as it means we'll still probably have to retry builds that bust the cache.
Configuration menu - View commit details
-
Copy full SHA for a09e9e9 - Browse repository at this point
Copy the full SHA a09e9e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf8e4f2 - Browse repository at this point
Copy the full SHA bf8e4f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18b776 - Browse repository at this point
Copy the full SHA b18b776View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ea4dd2 - Browse repository at this point
Copy the full SHA 4ea4dd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9019ae - Browse repository at this point
Copy the full SHA f9019aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90588a9 - Browse repository at this point
Copy the full SHA 90588a9View commit details -
Remove getopts leftover from tree
This was attempted but left incomplete in PR rust-lang#42664, where only the toml file was removed.
Configuration menu - View commit details
-
Copy full SHA for 700fd5a - Browse repository at this point
Copy the full SHA 700fd5aView commit details -
Rollup merge of rust-lang#48482 - davidtwco:issue-47184, r=nikomatsakis
NLL should identify and respect the lifetime annotations that the user wrote Part of rust-lang#47184. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 8921c16 - Browse repository at this point
Copy the full SHA 8921c16View commit details -
Rollup merge of rust-lang#49046 - Zoxc:error-summary, r=michaelwoerister
Always print `aborting due to n previous error(s)` r? @michaelwoerister
Configuration menu - View commit details
-
Copy full SHA for 19f8431 - Browse repository at this point
Copy the full SHA 19f8431View commit details -
Rollup merge of rust-lang#49089 - alexcrichton:fix-timings, r=Mark-Si…
…mulacrum rustbuild: Tweak where timing information goes This commit tweaks where timing and step information is printed out as part of the build, ensuring that we do it as close to the location where work happens as possible. In rustbuild various functions may perform long blocking work as dependencies are assembled, so if we print out timing information early on we may accidentally time more than just the step we were intending to time!
Configuration menu - View commit details
-
Copy full SHA for d17afd1 - Browse repository at this point
Copy the full SHA d17afd1View commit details -
Rollup merge of rust-lang#49101 - mark-i-m:stabilize_i128, r=nagisa
Stabilize 128-bit integers 🎉 cc rust-lang#35118 EDIT: This should be merged only after the following have been merged: - [x] rust-lang/compiler-builtins#236 - [x] rust-lang/book#1230
Configuration menu - View commit details
-
Copy full SHA for 20b5bf6 - Browse repository at this point
Copy the full SHA 20b5bf6View commit details -
Rollup merge of rust-lang#49121 - varkor:stabilise-from_utf8_error_as…
…_bytes, r=bluss Stabilise FromUtf8Error::as_bytes Closes rust-lang#40895.
Configuration menu - View commit details
-
Copy full SHA for 59b5887 - Browse repository at this point
Copy the full SHA 59b5887View commit details -
Rollup merge of rust-lang#49122 - scottmcm:z-align-attr, r=cramertj
Add a -Z flag for LLVM align attributes on arguments LLVM seems to still put the assume calls in when inlining, so this probably isn't in a place where it can be turned on by default, but it's interesting to experiment with. For example, this makes `mem::swap::<u64x8>` be 8x `vmovaps ymm` instead of 16x `vmovups xmm`, on my cpu.
Configuration menu - View commit details
-
Copy full SHA for 4a3b5f7 - Browse repository at this point
Copy the full SHA 4a3b5f7View commit details -
Rollup merge of rust-lang#49141 - gnzlbg:simd_select, r=alexcrichton
adds simd_select intrinsic The select SIMD intrinsic is used to select elements from two SIMD vectors using a mask: ```rust let mask = b8x4::new(true, false, false, true); let a = f32x4::new(1., 2., 3., 4.); let b = f32x4::new(5., 6., 7., 8.); assert_eq!(simd_select(mask, a, b), f32x4::new(1., 6., 7., 4.)); ``` The number of lanes between the mask and the vectors must match, but the vector width of the mask does not need to match that of the vectors. The mask is required to be a vector of signed integers. Note: this intrinsic will be exposed via `std::simd`'s vector masks - users are not expected to use it directly.
Configuration menu - View commit details
-
Copy full SHA for 9b0a43e - Browse repository at this point
Copy the full SHA 9b0a43eView commit details -
Rollup merge of rust-lang#49193 - davidtwco:issue-29893, r=alexcrichton
Host compiler documentation Fixes rust-lang#29893. Rust Central Station PR: rust-lang/rust-central-station#40 r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 6986057 - Browse repository at this point
Copy the full SHA 6986057View commit details -
Rollup merge of rust-lang#49194 - Zoxc:unsafe-generator, r=cramertj
Make resuming generators unsafe instead of the creation of immovable generators cc @withoutboats Fixes rust-lang#47787
Configuration menu - View commit details
-
Copy full SHA for 23ce530 - Browse repository at this point
Copy the full SHA 23ce530View commit details -
Rollup merge of rust-lang#49203 - Eijebong:lets-cleanup-dependencies,…
… r=Mark-Simulacrum Bump racer and home This removes 10 dependencies from the build 🎉
Configuration menu - View commit details
-
Copy full SHA for 7fbc373 - Browse repository at this point
Copy the full SHA 7fbc373View commit details -
Rollup merge of rust-lang#49235 - topecongiro:run-rustfmt/libtest, r=nrc
Configuration menu - View commit details
-
Copy full SHA for 414e1d8 - Browse repository at this point
Copy the full SHA 414e1d8View commit details -
Rollup merge of rust-lang#49249 - gnzlbg:simd_minmax, r=alexcrichton
implement minmax intrinsics This adds the `simd_{fmin,fmax}` intrinsics, which do a vertical (lane-wise) `min`/`max` for floating point vectors that's equivalent to Rust's `min`/`max` for `f32`/`f64`. It might make sense to make `{f32,f64}::{min,max}` use the `minnum` and `minmax` intrinsics as well. --- ~~HELP: I need some help with these. Either I should go to sleep or there must be something that I must be missing. AFAICT I am calling the `maxnum` builder correctly, yet rustc/LLVM seem to insert a call to `llvm.minnum` there instead...~~ EDIT: Rust's LLVM version is too old :/
Configuration menu - View commit details
-
Copy full SHA for 913adba - Browse repository at this point
Copy the full SHA 913adbaView commit details -
Rollup merge of rust-lang#49254 - Tacklebox:atan2_doc, r=QuietMisdreavus
Fixed clockwise/counter-clockwise in atan2 documentation in f32 and f64 and included that it returns radians None
Configuration menu - View commit details
-
Copy full SHA for 8a1731a - Browse repository at this point
Copy the full SHA 8a1731aView commit details -
Rollup merge of rust-lang#49273 - michaelwoerister:fix-extern-proc-ma…
…cro-defkey, r=eddyb Fix DefKey lookup for proc-macro crates. Add a special case for proc-macro crates for `def_key()` in the metadata decoder (like we already have for many other methods in there). In the long run, it would be preferable to get rid of the need for special casing proc-macro crates (see rust-lang#49271). Fixes rust-lang#48739 (though I wasn't able to come up with a regression test, unfortunately) r? @eddyb
Configuration menu - View commit details
-
Copy full SHA for cd9fb22 - Browse repository at this point
Copy the full SHA cd9fb22View commit details -
Rollup merge of rust-lang#49274 - oli-obk:slow_miri, r=michaelwoerist…
…er,eddyb Remove slow HashSet during miri stack frame creation fixes rust-lang#49237 probably has a major impact on rust-lang#48846 r? @michaelwoerister cc @eddyb I know you kept telling me to use vectors instead of hash containers... Now I know why.
Configuration menu - View commit details
-
Copy full SHA for f0ea0c7 - Browse repository at this point
Copy the full SHA f0ea0c7View commit details -
Rollup merge of rust-lang#49284 - alexcrichton:use-our-own-cache, r=k…
…ennytm ci: Don't use Travis caches for docker images This commit moves away from caching on Travis to our own caching on S3 for caching docker layers between builds. Unfortunately the Travis caches have over time had a few critical pain points: * Caches are only updated for successful builds, meaning that if a build times out or fails in a different location the sucessfully-created docker images isn't always cached. While this makes sense as a general rule of caches it hurts our use cases. * Caches are per-branch and builder which means that we don't have a separate cache on each release channel. All our merges go through the `auto` branch which means that they're all sharing the same cache, even those for merging to master/beta. This means that PRs which switch between master/beta will keep rebuilting and having cache misses. * Caches have historically been invaliated somewhat regularly a little more aggressively than we'd want (I think). * We don't always need to update the contents of the cache if the Docker image didn't change at all, and saving off the docker layers can sometimes be quite expensive. For all these reasons this commit drops the usage of Travis's built-in caching support. Instead our own caching is used by storing blobs to S3. Normally this would be a very risky endeavour but we're basically priming a cache for a cache (docker) so if we get this wrong the failure mode is longer builds, not stale caches. We'll notice that pretty quickly and hopefully fix it! The logic here is inserted directly into the `src/ci/docker/run.sh` script to download an image based on a shasum of the `Dockerfile` and other assorted files. This blob, if found, is loaded into docker and we record what layers were inserted. After docker finishes the build (hopefully quickly with lots of cache hits) we then see the sha of the final image. If it's one of the layers we loaded then there's no need to update the cache. Otherwise we upload our layers to the global cache, possibly overwriting what we previously just downloaded. This is hopefully a step towards mitigating rust-lang#49278 although it doesn't completely fix it as it means we'll still probably have to retry builds that bust the cache.
Configuration menu - View commit details
-
Copy full SHA for 8c653a7 - Browse repository at this point
Copy the full SHA 8c653a7View commit details -
Rollup merge of rust-lang#49290 - cuviper:unextended-dist-rustfmt, r=…
…nikomatsakis Allow installing rustfmt without config.extended This assertion was preventing `./x.py install rustfmt` if attempted without an "extended" build configuration, but it actually builds and installs just fine.
Configuration menu - View commit details
-
Copy full SHA for 6c73231 - Browse repository at this point
Copy the full SHA 6c73231View commit details -
Rollup merge of rust-lang#49311 - SimonSapin:bootstrap-vs-rustflags-t…
…he-return, r=Mark-Simulacrum Use the same RUSTFLAGS for building and testing `bootstrap` This avoids recompiling the whole dependency graph twice for every `./x.py test` run. Fixes rust-lang#49215
Configuration menu - View commit details
-
Copy full SHA for 0615e6b - Browse repository at this point
Copy the full SHA 0615e6bView commit details -
Rollup merge of rust-lang#49312 - GuillaumeGomez:fix-ie11-search, r=Q…
…uietMisdreavus Fix IE11 search Fixes rust-lang#49263. r? @QuietMisdreavus I got this code from: https://stackoverflow.com/a/30867255/7879548
Configuration menu - View commit details
-
Copy full SHA for 8cb9b83 - Browse repository at this point
Copy the full SHA 8cb9b83View commit details -
Rollup merge of rust-lang#49314 - Mark-Simulacrum:remove-getopts, r=a…
…lexcrichton Remove getopts leftover from tree This was attempted but left incomplete in PR rust-lang#42664, where only the toml file was removed. cc @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for b928781 - Browse repository at this point
Copy the full SHA b928781View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba92a7b - Browse repository at this point
Copy the full SHA ba92a7bView commit details
Commits on Mar 24, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bbdb20a - Browse repository at this point
Copy the full SHA bbdb20aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 455e542 - Browse repository at this point
Copy the full SHA 455e542View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc23686 - Browse repository at this point
Copy the full SHA fc23686View commit details