Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #55295

Closed
wants to merge 56 commits into from
Closed

Commits on Sep 27, 2018

  1. rustc: Tweak filenames encoded into metadata

    This commit is a fix for rust-lang#54408 where on nightly right now whenever
    generics are inlined the path name listed for the inlined function's
    debuginfo is a relative path to the cwd, which surely doesn't exist!
    Previously on beta/stable the debuginfo mentioned an absolute path which
    still didn't exist, but more predictably didn't exist.
    
    The change between stable/nightly is that nightly is now compiled with
    `--remap-path-prefix` to give a deterministic prefix to all
    rustc-generated paths in debuginfo. By using `--remap-path-prefix` the
    previous logic would recognize that the cwd was remapped, causing the
    original relative path name of the standard library to get emitted. If
    `--remap-path-prefix` *wasn't* passed in then the logic would create an
    absolute path name and then create a new source file entry.
    
    The fix in this commit is to apply the "recreate the source file entry
    with an absolute path" logic a bit more aggresively. If the source
    file's name was remapped then we don't touch it, but otherwise we always
    take the working dir (which may have been remapped) and then join it to
    the file to ensure that we process all relative file names as well.
    
    The end result is that the standard library should have an absolute path
    for all file names in debuginfo (using our `--remap-path-prefix`
    argument) as it does on stable after this patch.
    
    Closes rust-lang#54408
    alexcrichton committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    63c471e View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. update tcp stream documentation

    Charles Hathaway committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    c514b62 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Small changes to fix documentation auto compile issues

    Charles Hathaway committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    4530b8c View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. Configuration menu
    Copy the full SHA
    7892257 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e650081 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8223380 View commit details
    Browse the repository at this point in the history
  4. Address comments

    varkor committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    55d2607 View commit details
    Browse the repository at this point in the history
  5. Fix Ref inhabitedness comment

    varkor committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    47e34a2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7bb2980 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6c235cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0830650 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7e14ffb View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. AST-borrowck: add separate mem category for thread-locals, as they ar…

    …e not quite rvalues
    
    (and of course they are not quite statics either).
    
    Namely, they *do* have a restricted region (like rvalues), but they
    also cannot be moved out of (like statics).
    pnkfelix committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    a75f781 View commit details
    Browse the repository at this point in the history
  2. Update existing tests and .stderr files to reflect introduction of th…

    …read-local mem category.
    pnkfelix committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    e6e4fe6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d46ce5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. Configuration menu
    Copy the full SHA
    1cf94f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. Configuration menu
    Copy the full SHA
    aa0875a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. Configuration menu
    Copy the full SHA
    655f9d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. submodules: update clippy from 5afdf8b to b1d0343

    Changes:
    ````
    new_ret_no_self: add sample from rust-lang#3313 to Known Problems section.
    Support multiline comments and hopefully fix panic
    Check for comments in collapsible ifs
    Resolve ICE in needless range loop lint
    RIIR update_lints: Update changelog links
    Rename if_let_redundant_pattern_matching to redundant_pattern_matching
    Add lint for redundant pattern matching for explicit return boolean
    Fix issue rust-lang#3322: reword help message for len_zero
    Simplify manual_memcpy suggestion in some cases
    Fix dogfood
    Update known problems for unnecessary_fold
    RIIR update_lints: Replace lint count in README.md
    Rename `active_lints` to `usable_lints`
    Add comment on WalkDir vs. fs::read_dir
    sort_by -> sort_by_key
    Some more documentation for clippy_dev
    Use `WalkDir` to also gather from subdirectories
    Avoid linting `boxed_local` on trait implementations.
    Website: Make lint categories linkable
    Restore clippy_dummy's placeholder name
    Swap order of methods in `needless_range_loop` suggestion in some cases
    Revert "Exclude pattern guards from unnecessary_fold lint"
    Exclude pattern guards from unnecessary_fold lint
    ````
    matthiaskrgr committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    9378705 View commit details
    Browse the repository at this point in the history
  2. Clarified code example

    The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of collection elements by the item size. This change demonstrates the idea more straightforwardly, without the calculation.
    peterjoel committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0f6e274 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f70096 View commit details
    Browse the repository at this point in the history
  4. only issue "variant of the expected type" suggestion for enums

    Felix S. Klock II pointed out that this suggestion (introduced in
    pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct
    expected types (in which case it is misleading and outright wrong),
    even though it was only intended for one-field enum-variants (most
    notably, `Some`). Particularly tender-hearted code-historians may be
    inclined to show mercy towards the author of rust-lang#43178 on the grounds
    that it's somewhat confusing that struct field definitions are given
    in a type called `ty::VariantDef`.
    
    Add a conditional to adhere to the original intent. (It would be
    possible to generalize to structs, but not obviously net desirable.)
    This adds a level of indentation, so the diff here is going to be
    easier to read in ignore-whitespace mode (`-w`).
    
    Resolves rust-lang#55250.
    zackmdavis committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    b0d3d3b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c675111 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Configuration menu
    Copy the full SHA
    9f0a352 View commit details
    Browse the repository at this point in the history
  2. Reproduce the underlying issue

    nll (and thus the algorithm for actual promotion) don't know about some casts anymore
    oli-obk committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    0ba1262 View commit details
    Browse the repository at this point in the history
  3. Unimplement ExactSizeIterator

    If root is not START_BLOCK, `basic_blocks().len() - visited` does not represent
    their exact size.
    sinkuu committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    80a6b73 View commit details
    Browse the repository at this point in the history
  4. Add note linking to Rust 2018 path semantics docs.

    This commit extends existing path suggestions to link to documentation
    on the changed semantics of `use` in Rust 2018.
    davidtwco committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    d2baf92 View commit details
    Browse the repository at this point in the history
  5. Suggest appropriate syntax on missing lifetime specifier in return type

    Suggest using `'static` when a lifetime is missing in the return type
    with a structured suggestion instead of a note.
    estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    e1e52eb View commit details
    Browse the repository at this point in the history
  6. review comments

    estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    d0bd69a View commit details
    Browse the repository at this point in the history
  7. [review comments] modify test and clean up code

    Co-Authored-By: estebank <esteban@kuber.com.ar>
    oli-obk and estebank committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    dd91c8f View commit details
    Browse the repository at this point in the history
  8. Fix Rustdoc ICE when checking blanket impls

    Fixes rust-lang#55001, rust-lang#54744
    
    Previously, SelectionContext would unconditionally cache the selection
    result for an obligation. This worked fine for most users of
    SelectionContext, but it caused an issue when used by Rustdoc's blanket
    impl finder.
    
    The issue occured when SelectionContext chose a ParamCandidate which
    contained inference variables. Since inference variables can change
    between calls to select(), it's not safe to cache the selection result -
    the chosen candidate might not be applicable for future results, leading
    to an ICE when we try to run confirmation.
    
    This commit prevents SelectionContext from caching any ParamCandidate
    that contains inference variables. This should always be completely
    safe, as trait selection should never depend on a particular result
    being cached.
    
    I've also added some extra debug!() statements, which I found helpful in
    tracking down this bug.
    Aaron1011 committed Oct 22, 2018
    Configuration menu
    Copy the full SHA
    4f2624c View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Remove redundant clone

    sinkuu committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    fda3326 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d960a5 View commit details
    Browse the repository at this point in the history
  3. Do some copy editing on the release notes

    I was reading through the release notes to find something and noticed
    some small grammatical and consistency issues.
    carols10cents committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    8d6ee8f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4972bea View commit details
    Browse the repository at this point in the history
  5. Update stdsimd submodule

    Fixes a SSE2 bug.
    kazcw committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    3d9231c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f912fda View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#54125 - varkor:less-conservative-uninhabite…

    …dness-check, r=nikomatsakis
    
    Less conservative uninhabitedness check
    
    Extends the uninhabitedness check to structs, non-empty enums, tuples and arrays.
    
    Pulled out of rust-lang#47291 and rust-lang#50262.
    
    Fixes rust-lang#54586.
    
    r? @nikomatsakis
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    7ee68d7 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#54626 - alexcrichton:dwarf-generics, r=mich…

    …aelwoerister
    
    rustc: Tweak filenames encoded into metadata
    
    This commit is a fix for rust-lang#54408 where on nightly right now whenever
    generics are inlined the path name listed for the inlined function's
    debuginfo is a relative path to the cwd, which surely doesn't exist!
    Previously on beta/stable the debuginfo mentioned an absolute path which
    still didn't exist, but more predictably didn't exist.
    
    The change between stable/nightly is that nightly is now compiled with
    `--remap-path-prefix` to give a deterministic prefix to all
    rustc-generated paths in debuginfo. By using `--remap-path-prefix` the
    previous logic would recognize that the cwd was remapped, causing the
    original relative path name of the standard library to get emitted. If
    `--remap-path-prefix` *wasn't* passed in then the logic would create an
    absolute path name and then create a new source file entry.
    
    The fix in this commit is to apply the "recreate the source file entry
    with an absolute path" logic a bit more aggresively. If the source
    file's name was remapped then we don't touch it, but otherwise we always
    take the working dir (which may have been remapped) and then join it to
    the file to ensure that we process all relative file names as well.
    
    The end result is that the standard library should have an absolute path
    for all file names in debuginfo (using our `--remap-path-prefix`
    argument) as it does on stable after this patch.
    
    Closes rust-lang#54408
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    b4df53e View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#54965 - chathaway-codes:update-tcp-stream-d…

    …ocs, r=GuillaumeGomez
    
    update tcp stream documentation
    
    A small styling issue that seemed inconsistent here when compared to other places (such as https://doc.rust-lang.org/beta/std/net/struct.TcpListener.html).
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    6948e8e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#55150 - pnkfelix:issues-47215-54797-fix-ice…

    …-from-moving-out-of-thread-local-under-ast-borrowck, r=nikomatsakis
    
    Do not allow moving out of thread local under ast borrowck
    
    AST borrowck failed to prevent moving out of a thread-local static.
    
    This was broken. And it also (sometimes?) caused an ICE during drop elaboration.
    
    Fix rust-lang#47215
    Fix rust-lang#54797
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    d3ac7c4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#55173 - estebank:suggest-static, r=oli-obk

    Suggest appropriate syntax on missing lifetime specifier in return type
    
    Suggest using `'static` when a lifetime is missing in the return type
    with a structured suggestion instead of a note.
    
    Fix rust-lang#55170.
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    830c6b0 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis

    path suggestions in Rust 2018 should point out the change in semantics
    
    Fixes rust-lang#55130.
    
    This commit extends existing path suggestions to link to documentation
    on the changed semantics of `use` in Rust 2018.
    
    r? @nikomatsakis
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    a083070 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#55225 - bjorn3:rustc_link, r=cramertj

    Move cg_llvm::back::linker to cg_utils
    
    This allows it to be reused by alternative codegen backends.
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    84722a4 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#55245 - matthiaskrgr:clippy, r=nikomatsakis

    submodules: update clippy from 5afdf8b to b1d0343
    
    Just a routine update.
    
    Changes:
    ````
    new_ret_no_self: add sample from rust-lang#3313 to Known Problems section.
    Support multiline comments and hopefully fix panic
    Check for comments in collapsible ifs
    Resolve ICE in needless range loop lint
    RIIR update_lints: Update changelog links
    Rename if_let_redundant_pattern_matching to redundant_pattern_matching
    Add lint for redundant pattern matching for explicit return boolean
    Fix issue rust-lang#3322: reword help message for len_zero
    Simplify manual_memcpy suggestion in some cases
    Fix dogfood
    Update known problems for unnecessary_fold
    RIIR update_lints: Replace lint count in README.md
    Rename `active_lints` to `usable_lints`
    Add comment on WalkDir vs. fs::read_dir
    sort_by -> sort_by_key
    Some more documentation for clippy_dev
    Use `WalkDir` to also gather from subdirectories
    Avoid linting `boxed_local` on trait implementations.
    Website: Make lint categories linkable
    Restore clippy_dummy's placeholder name
    Swap order of methods in `needless_range_loop` suggestion in some cases
    Revert "Exclude pattern guards from unnecessary_fold lint"
    Exclude pattern guards from unnecessary_fold lint
    ````
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    9f33d7e View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#55247 - peterjoel:peterjoel-prim-char-doc-e…

    …xample, r=joshtriplett
    
    Clarified code example in char primitive doc
    
    The example was not as clear as it could be because it was making an assumption about the structure of the data in order to multiply the number of elements in the slice by the item size. This change demonstrates the idea more straightforwardly, without needing a calculation, by just comparing the size of the slices.
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    9687c02 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#55251 - NieDzejkob:master, r=TimNN

    Fix a typo in the documentation of RangeInclusive
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    7f46193 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#55253 - zackmdavis:some_suggestion, r=pnkfelix

    only issue "variant of the expected type" suggestion for enums
    
    This suggestion (introduced in pull-request rust-lang#43178 / eac7410) was being issued for one-field-struct expected types (in which case it is misleading and outright wrong), even though it was only intended for one-field enum-variants (most notably, `Some`).
    
    Add a conditional to adhere to the original intent. (It would be possible to generalize to structs, but not obviously net desirable.) This adds a level of indentation, so the diff here is going to be
    easier to read in [ignore-whitespace mode](rust-lang@b0d3d3b9?w=1).
    
    Resolves rust-lang#55250.
    
    r? @pnkfelix
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    a2f3cc3 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#55254 - rust-lang:clean-two-dots, r=Guillau…

    …meGomez
    
    Correct trailing ellipsis in name_from_pat
    
    r? @GuillaumeGomez
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    9dcdb63 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#55258 - Aaron1011:fix/rustdoc-blanket, r=Gu…

    …illaumeGomez
    
    Fix Rustdoc ICE when checking blanket impls
    
    Fixes rust-lang#55001, rust-lang#54744
    
    Previously, SelectionContext would unconditionally cache the selection
    result for an obligation. This worked fine for most users of
    SelectionContext, but it caused an issue when used by Rustdoc's blanket
    impl finder.
    
    The issue occured when SelectionContext chose a ParamCandidate which
    contained inference variables. Since inference variables can change
    between calls to select(), it's not safe to cache the selection result -
    the chosen candidate might not be applicable for future results, leading
    to an ICE when we try to run confirmation.
    
    This commit prevents SelectionContext from caching any ParamCandidate
    that contains inference variables. This should always be completely
    safe, as trait selection should never depend on a particular result
    being cached.
    
    I've also added some extra debug!() statements, which I found helpful in
    tracking down this bug.
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    a7362db View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#55262 - oli-obk:dangling_alloc_id_ice, r=Ra…

    …lfJung
    
    Change the ICE from rust-lang#55223 to a hard error
    
    cc @SimonSapin
    
    r? @RalfJung
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    1197831 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#55269 - matthiaskrgr:typos_oct, r=zackmdavis

    fix typos in various places
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    21d000c View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#55271 - sinkuu:traversal_iter, r=matthewjasper

    Unimplement ExactSizeIterator for MIR traversing iterators
    
    If `root` is not `START_BLOCK`, `basic_blocks().len() - visited` does not represent their exact size.
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    3096b4a View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#55282 - sinkuu:redundant_clone, r=estebank

    Remove redundant clone
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    070dcf8 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#55285 - integer32llc:release-notes-improvem…

    …ents, r=Aaronepower
    
    Do some copy editing on the release notes
    
    I was reading through the release notes to find something and noticed
    some small grammatical and consistency issues.
    
    I'm happy to revert any of these changes if folks disagree with them!
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    59a0a44 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#55291 - kazcw:master, r=nikomatsakis

    Update stdsimd submodule
    
    Fixes a SSE2 bug. (rust-lang#55249)
    pietroalbini committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    b51c215 View commit details
    Browse the repository at this point in the history