Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 23 pull requests #56743

Closed
wants to merge 60 commits into from
Closed

Rollup of 23 pull requests #56743

wants to merge 60 commits into from

Commits on Nov 28, 2018

  1. Remove not used mod

    `mir_stats` mod has not been used since c1ff104.
    yui-knk committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    934e4d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Configuration menu
    Copy the full SHA
    eaeebb5 View commit details
    Browse the repository at this point in the history
  2. Fix line length

    JohnGinger committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    54026c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Fix stderr files

    JohnGinger committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    4cf5702 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70536d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Unique/NonNull::from: make sure we convert to raw pointers ASAP

    By going through a shared reference, we share the destination as read-only, meaning we can read but not write with the raw pointers
    RalfJung committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    21b5950 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0c4a35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    feb775c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c0e3f4b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86822eb View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. rustdoc: Fix local reexports of proc macros

    Filter out `ProcMacroStub`s to avoid an ICE during cleaning.
    
    Also add proc macros to `cache().paths` so it can generate links.
    ollie27 committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    0bb075f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2018

  1. Configuration menu
    Copy the full SHA
    aa04285 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85b50d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. bootstrap: fix edition

    ljedrz committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    a5a3da5 View commit details
    Browse the repository at this point in the history
  2. reject invalid external doc attributes

    Also, provide a suggestion for the correct syntax.
    euclio committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    c3c2de9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f7045f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5586c04 View commit details
    Browse the repository at this point in the history
  5. Update the stdsimd submodule

    Includes some new stabilized intrinsics for the wasm32 target!
    
    Closes rust-lang#56292
    alexcrichton committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    07a3d69 View commit details
    Browse the repository at this point in the history
  6. fix install broken link

    mishaker committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    3d23e55 View commit details
    Browse the repository at this point in the history
  7. Add lint for stlib

    aheart committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    f8c03b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Configuration menu
    Copy the full SHA
    771e8b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8839f15 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8111824 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    442abbc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    799cadb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1346619 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5457b19 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    30f531b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8ee2c06 View commit details
    Browse the repository at this point in the history
  10. Always set the RDRAND and RDSEED features on SGX

    Jethro Beekman committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    5acab2d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    45b97f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b17a3f2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8e994a2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b96186b View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Fix gpg signing in manifest builder

    GPG versions 2.x+ require that --batch be passed if --passphrase-fd is
    to be accepted.
    Mark-Simulacrum committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    4d5413b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    517bfe0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76cb35e View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#56161 - RalfJung:vecdeque-stacked-borrows, …

    …r=SimonSapin
    
    VecDeque: fix for stacked borrows
    
    `VecDeque` violates a version of stacked borrows where creating a shared reference is not enough to make a location *mutably accessible* from raw pointers (and I think that is the version we want).  There are two problems:
    
    * Creating a `NonNull<T>` from `&mut T` goes through `&T` (inferred for a `_`), then `*const T`, then `NonNull<T>`. That means in this stricter version of Stacked Borrows, we cannot actually write to such a `NonNull` because it was created from a shared reference! This PR fixes that by going from `&mut T` to `*mut T` to `*const T`.
    * `VecDeque::drain` creates the `Drain` struct by *first* creating a `NonNull` from `self` (which is an `&mut VecDeque`), and *then* calling `self.buffer_as_mut_slice()`. The latter reborrows `self`, asserting that `self` is currently the unique pointer to access this `VecDeque`, and hence invalidating the `NonNull` that was created earlier. This PR fixes that by instead using `self.buffer_as_slice()`, which only performs read accesses and creates only shared references, meaning the raw pointer (`NonNull`) remains valid.
    
    It is possible that other methods on `VecDeque` do something similar, miri's test coverage of `VecDeque` is sparse to say the least.
    
    Cc @nikomatsakis @gankro
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    32b9f78 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#56203 - aheart:master, r=varkor

    Add lint for items deprecated in future
    
    Resolves rust-lang#55892
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    dadc916 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#56343 - yui-knk:remove_mir_stats_mod, r=nik…

    …omatsakis
    
    Remove not used mod
    
    `mir_stats` mod has not been used since c1ff104.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    af755f8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#56439 - JohnGinger:master, r=nikomatsakis

    Clearer error message for dead assign
    
    I'm not that this is the right place for this (if it needs an RFC or not).
    
    I had the problem where I misunderstood the compiler lint message rust-lang#56436 and other people seem to have had the same problem https://www.reddit.com/r/rust/comments/8cy9p4/value_assigned_to_is_never_read/.
    
    I think this new wording might be slightly clearer (and help out beginners like me). I'm very new though, so there might be some nuance I'm missing that would make this more confusing or a bad idea for other reasons.
    
    I thought I would create a PR to make it easy to change the code if the consensus was that it would make sense to make a change.
    
    If this is the wrong place for this sort of thing I'll happily delete/move it.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    a35ece4 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#56490 - faern:add-checked-add-to-instant, r…

    …=alexcrichton
    
    Add checked_add method to Instant time type
    
    Appending functionality to the already opened topic of `checked_add` on time types over at rust-lang#55940.
    
    Doing checked addition between an `Instant` and a `Duration` is important to reliably determine a future instant. We could use this in the `parking_lot` crate to compute an instant when in the future to wake a thread up without risking a panic.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    346d64d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#56507 - nikomatsakis:polonius-integrate, r=…

    …MatthewJasper
    
    polonius tweaks
    
    - bump polonius to 0.6.0
    - fix 2-phase-borrow activations
    
    r? @matthewjasper
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    e8ab05b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#56572 - kevgrasso:let_self_err_dev, r=estebank

    Contexually dependent error message for E0424 when value is assigned to "self"
    
    This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report:
    ```
    let self = "self";
        ^^^^ `self` value is a keyword and may not be bound to variables or shadowed
    ```
    instead of
    ```
    let self = "self";
        ^^^^ `self` value is a keyword only available in methods with `self` parameter
    ```
    If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3df2e7f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#56600 - ljedrz:fix_edition, r=Mark-Simulacrum

    bootstrap: fix edition
    
    A byproduct of work on rust-lang#56595; done with `cargo fix --edition`.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    613f082 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#56609 - michaelwoerister:unconditional-targ…

    …et-cpu-attr, r=alexcrichton
    
    Unconditionally emit the target-cpu LLVM attribute.
    
    This PR makes `rustc` always emit the `target-cpu` LLVM attribute for functions. The goal is to allow for cross-language inlining of functions defined in `libstd`. So far `libstd` functions were the only function without a `target-cpu` attribute, so in whole-crate-graph cross-lang LTO scenarios they were not eligible for inlining into foreign code.
    
    r? @alexcrichton
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    b4d16ef View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#56637 - ollie27:rustdoc_proc_macro_local_re…

    …export, r=QuietMisdreavus
    
    rustdoc: Fix local reexports of proc macros
    
    Filter out `ProcMacroStub`s to avoid an ICE during cleaning.
    
    Also add proc macros to `cache().paths` so it can generate links.
    
    r? @QuietMisdreavus
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    339a465 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#56658 - Xanewok:non-panicking-file-parser, …

    …r=petrochenkov
    
    Add non-panicking `maybe_new_parser_from_file` variant
    
    Add (seemingly?) missing `maybe_new_parser_from_file` constructor variant.
    
    Disclaimer: I'm not certain this is the correct approach - just found out we don't have this when working on a Rustfmt PR to catch/prevent more Rust parser panics: rust-lang/rustfmt#3240 and tried to make it work somehow.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    c03c7b9 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#56679 - euclio:external-doc-parse, r=estebank

    overhaul external doc attribute diagnostics
    
    This PR improves the error handling and spans for the external doc attribute. Many cases that silently failed before now emit errors, spans are tightened, and the errors have help and suggestions.
    
    I tried to address all the cases that users ran into in the tracking issue.
    
    cc rust-lang#44732
    
    r? @QuietMisdreavus
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    fe5dc91 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#56682 - alexcrichton:update-stdsimd, r=niko…

    …matsakis
    
    Update the stdsimd submodule
    
    Includes some new stabilized intrinsics for the wasm32 target!
    
    Closes rust-lang#56292
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    03045b4 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#56691 - mishaker:fix_doc_install_broken_lin…

    …k, r=jonas-schievink
    
    fix install broken link
    
    solves rust-lang#56690
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d226199 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#56702 - wesleywiser:calc_total_time_stats, …

    …r=michaelwoerister
    
    [self-profiler] Add column for percent of total time
    
    Example output:
    
    ```
    Self profiling results:
    
    | Phase            | Time (ms)      | Time (%) | Queries        | Hits (%)
    | ---------------- | -------------- | -------- | -------------- | --------
    | Parsing          | 3              | 0.52     |                |
    | Expansion        | 64             | 11.27    |                |
    | TypeChecking     | 13             | 2.36     | 35208          | 90.77
    | BorrowChecking   | 0              | 0.10     | 68             | 50.00
    | Codegen          | 22             | 3.82     | 7362           | 75.12
    | Linking          | 252            | 43.81    | 458            | 68.56
    | Other            | 219            | 38.12    | 47372          | 56.84
    
    Optimization level: No
    Incremental: off
    
    ```
    
    cc @michaelwoerister
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    b7fef81 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#56708 - oli-obk:stability_internal_const_fn…

    …, r=alexcrichton
    
    Remove some unnecessary feature gates
    
    fixes rust-lang#56585
    
    cc @jethrogb
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3377af6 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#56710 - jethrogb:jb/sgx-target-features, r=…

    …alexcrichton
    
    Always set the RDRAND and RDSEED features on SGX
    
    Not sure if this is 100% correct.
    
    This [Intel article](https://software.intel.com/en-us/articles/intel-software-guard-extensions-tutorial-part-5-enclave-development) goes in great depth regarding using (untrusted) CPUID to see whether RDRAND/RDSEED is supported, and explains what happens to the enclave if the CPUID result is faked.
    
    I'd say that an implementation of SGX that doesn't make RDRAND available to the enclave is so severely limited/broken that it's ok if you get #UD in that case. The case is less clear for RDSEED, but it so far every processor released by Intel with SGX support also has RDSEED (including Gemini Lake).
    
    cc @briansmith
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    addcd3e View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#56718 - RalfJung:use-libbacktrace-printing,…

    … r=alexcrichton
    
    Use libbacktrace pretty-printing
    
    r? @alexcrichton
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    d8c198e View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#56725 - piersfinlayson:master, r=alexcrichton

    fix rust-lang/rust issue rust-lang#50583
    
    Rationale for the fix is in rust-lang#50583.  I've verified that before the fix /musl-armhf/lib/libc.a is riddled with the illegal variant of vmov.f64 and after the fix the version built doesn't contain any of these illegal instructions.
    
    I originally thought that the arm-linux-gnueabi version also needed fixing - to add a -mfloat-abi-soft but that's unnecessary as it's compiled with the gnueabi (not hf) compiler (I've some a quick check that the libc.a produced doesn't include VFP instructions).
    
    r? @alexcrichton
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    7e8c317 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#56731 - GuillaumeGomez:ffi-doc-urls, r=Centril

    Add missing urls in ffi module docs
    
    r? @QuietMisdreavus
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3e2d427 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#56735 - Mark-Simulacrum:fix-sign, r=alexcri…

    …chton
    
    Fix gpg signing in manifest builder
    
    GPG versions 2.x+ require that --batch be passed if --passphrase-fd is
    to be accepted.
    
    From the man page:
    
           --passphrase-fd n
                  Read  the passphrase from file descriptor n. Only the first line
                  will be read from file descriptor n. If you use  0  for  n,  the
                  passphrase  will  be  read  from STDIN. This can only be used if
                  only one passphrase is supplied.
    
                  Note that this passphrase is only used if the option --batch has
                  also been given.  This is different from GnuPG version 1.x.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    314577f View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#56738 - turboladen:fix-private_no_mangle_fn…

    …s-message, r=zackmdavis
    
    Fix private_no_mangle_fns message grammar
    
    Simply changes "an warning" to "a warning" in the `private_no_mangle_fns` warning. I started getting this in some code after upgrading to 1.31.0.
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3b4c85a View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#56742 - ljedrz:remove_query_response_box, r…

    …=oli-obk
    
    infer: remove Box from a returned Iterator
    kennytm committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    5f41f84 View commit details
    Browse the repository at this point in the history