triagebot.toml: add ping aliases #69949
Conversation
rust-highfive
added
the
S-waiting-on-review
|
This is great 👍. I was just wondering if adding a lot of aliases to cleanup crew is not more confusing. Isn't with cleanup enough?. |
|
I basically included some things that I would commonly think of when thinking of the group; basically things that the crew does. |
triagebot.toml
Outdated
| @@ -22,6 +23,7 @@ Thanks! <3 | |||
| label = "ICEBreaker-LLVM" | |||
|
|
|||
| [ping.icebreakers-cleanup-crew] | |||
| alias = ["cleanup", "shrink", "reduce", "bisect"] | |||
There was a problem hiding this comment.
I would personally prefer that we avoid adding all the aliases we can think of - is cleanup not enough?
There was a problem hiding this comment.
There were more that I thought of... ;) ...but these were the ones which I associate the task with most closely, i.e. I associate the actual work more closely with bisecting or shrinking than with "cleanup" (which I also associate with C-cleanup, and that isn't what this is about). Imo having more aliases which aren't misleading means folks are more likely to get the bot to do what they want. (It's good to make the bot fault tolerant, e.g. cleanups (with the s at the end) would be a good extension I think.)
There was a problem hiding this comment.
I don't want to try to make the code itself fault tolerant in that respect, but I suppose I can buy this argument. Could you add cleanups and such as well then? r=me with that
There was a problem hiding this comment.
Added "llvms" and "cleanups". We can add more variations if people make those mistakes. :)
|
@bors r=Mark-Simulacrum |
|
📌 Commit 90e8058 has been approved by |
bors
added
S-waiting-on-bors
…ark-Simulacrum triagebot.toml: add ping aliases I think I got the syntax right. Closes rust-lang/triagebot#402. r? @Mark-Simulacrum cc @pnkfelix
Rollup of 8 pull requests Successful merges: - #68746 (Make macro metavars respect (non-)hygiene) - #69189 (Erase regions in writeback) - #69402 (Extend search) - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69949 (triagebot.toml: add ping aliases) Failed merges: - #69589 (ast: `Mac`/`Macro` -> `MacCall`) r? @ghost
…ark-Simulacrum triagebot.toml: add ping aliases I think I got the syntax right. Closes rust-lang/triagebot#402. r? @Mark-Simulacrum cc @pnkfelix
Rollup of 12 pull requests Successful merges: - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69723 (Added doc on keyword Pub.) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69947 (Clean up E0423 explanation) - #69949 (triagebot.toml: add ping aliases) - #69954 (rename panic_if_ intrinsics to assert_) - #69960 (miri engine: fix treatment of abort intrinsic) - #69966 (Add more regression tests) - #69973 (Update stable-since version for const_int_conversion) - #69974 (Clean up E0434 explanation) Failed merges: r? @ghost
I think I got the syntax right.
Closes rust-lang/triagebot#402.
r? @Mark-Simulacrum
cc @pnkfelix