Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #69986

Merged
merged 43 commits into from
Mar 13, 2020
Merged

Rollup of 12 pull requests #69986

merged 43 commits into from
Mar 13, 2020

Conversation

JohnTitor
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

LeSeulArtichaut and others added 30 commits February 23, 2020 18:32
sjud and others added 13 commits March 13, 2020 11:12
…r=RalfJung

Move some `build-pass` tests to `check-pass`

Helps with rust-lang#62277.

r? @cramertj cc @Centril
…acrum

Added doc on keyword Pub.

Hi, this is my first pull request. I hope it's OK. Please let me know if it would benefit from any changes. Thank you.
fix more clippy findings

* reduce references on match patterns (clippy::match_ref_pats)
* Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline)
* libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string)
* remove unneeded mutable references (cippy::unnecessary_mut_passed)
* libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast)
* rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes)
* call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)
* iterate over a maps values directly. (clippy::for_kv_map)
* rustdoc: simplify boolean condition (clippy::nonminimal_bool)
* Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
* rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some)
* rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)
remove lifetimes that can be elided (clippy::needless_lifetimes)
…ark-Simulacrum

triagebot.toml: add ping aliases

I think I got the syntax right.
Closes rust-lang/triagebot#402.

r? @Mark-Simulacrum
cc @pnkfelix
miri engine: fix treatment of abort intrinsic

I screwed up in rust-lang#69830 and added `abort` to the wrong block of intrinsics, namely the one that actually has a return place. So that branch was never actually reached.

r? @oli-obk
…, r=dtolnay

Update stable-since version for const_int_conversion

Since rust-lang#69373 was not merged in time for 1.43.0 beta, update to `since = "1.44.0"`.
@JohnTitor
Copy link
Member Author

@bors r+ rollup=never p=12

@bors
Copy link
Contributor

bors commented Mar 13, 2020

📌 Commit 1d8f5f0 has been approved by JohnTitor

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 13, 2020
@JohnTitor JohnTitor added the rollup A PR which is a rollup label Mar 13, 2020
@bors
Copy link
Contributor

bors commented Mar 13, 2020

⌛ Testing commit 1d8f5f0 with merge 1572c43...

@bors
Copy link
Contributor

bors commented Mar 13, 2020

☀️ Test successful - checks-azure
Approved by: JohnTitor
Pushing 1572c43 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants