Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a codegen test for a recent optimization for overflow-checks=on #72547

Merged
merged 1 commit into from
May 29, 2020

Conversation

alex
Copy link
Member

@alex alex commented May 24, 2020

Closes #58692

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2020
@nikomatsakis
Copy link
Contributor

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented May 27, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 27, 2020

📌 Commit cd5f228 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 27, 2020
Added a codegen test for a recent optimization for overflow-checks=on

Closes rust-lang#58692
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 27, 2020
Added a codegen test for a recent optimization for overflow-checks=on

Closes rust-lang#58692
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 28, 2020
Added a codegen test for a recent optimization for overflow-checks=on

Closes rust-lang#58692
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2020
Rollup of 11 pull requests

Successful merges:

 - rust-lang#71633 (Impl Error for Infallible)
 - rust-lang#71843 (Tweak and stabilize AtomicN::fetch_update)
 - rust-lang#72288 (Stabilization of weak-into-raw)
 - rust-lang#72324 (Stabilize AtomicN::fetch_min and AtomicN::fetch_max)
 - rust-lang#72452 (Clarified the documentation for Formatter::precision)
 - rust-lang#72495 (Improve E0601 explanation)
 - rust-lang#72534 (Improve missing `@` in slice binding pattern diagnostics)
 - rust-lang#72547 (Added a codegen test for a recent optimization for overflow-checks=on)
 - rust-lang#72711 (remove redundant `mk_const`)
 - rust-lang#72713 (Whitelist #[allow_internal_unstable])
 - rust-lang#72720 (Clarify the documentation of `take`)

Failed merges:

r? @ghost
@bors bors merged commit 05229f7 into rust-lang:master May 29, 2020
@alex alex deleted the patch-1 branch May 29, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed optimization: extra branch with slicing and integer overflow checks
5 participants