Fix sizes of repr(C) enums on hexagon #82379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Enums on hexagon use a smallest size (but at least 1 byte) that fits all the enumeration values. This is unlike many other ABIs where enums are at least 32 bits.
nagisa
force-pushed
the
nagisa/hexagon-enums
branch
from
8cf7a70
to
7130e46
Compare
|
@bors r+ |
|
📌 Commit 7130e46 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 22, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#82098 (Add internal `collect_into_array[_unchecked]` to remove duplicate code) - rust-lang#82228 (Provide NonZero_c_* integers) - rust-lang#82287 (Make "missing field" error message more natural) - rust-lang#82351 (Use the first paragraph, instead of cookie-cutter text, for rustdoc descriptions) - rust-lang#82353 (rustdoc: Remove unnecessary `Cell` around `param_env`) - rust-lang#82367 (remove redundant option/result wrapping of return values) - rust-lang#82372 (improve UnsafeCell docs) - rust-lang#82379 (Fix sizes of repr(C) enums on hexagon) - rust-lang#82382 (rustdoc: Remove `fake_def_ids` RefCell) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@nagisa // needs-llvm-components: hexagonannotation to the added test? |
|
Definitely, will submit a PR for this later today. |
nagisa
added a commit
to nagisa/rust
that referenced
this pull request
Feb 22, 2021
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 24, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? `@petrochenkov` `@bors` rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 24, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? ``@petrochenkov`` ``@bors`` rollup
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 24, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? ```@petrochenkov``` ```@bors``` rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 26, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? ````@petrochenkov```` ````@bors```` rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 27, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? `````@petrochenkov````` `````@bors````` rollup
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 27, 2021
…mps, r=petrochenkov Test hexagon-enum only when llvm target is present See rust-lang#82379 (comment) r? ``````@petrochenkov`````` ``````@bors`````` rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums on hexagon use a smallest size (but at least 1 byte) that fits all
the enumeration values. This is unlike many other ABIs where enums are
at least 32 bits.
Fixes #82100