Update Clippy #90564
Merged
Update Clippy #90564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was dues to the constant bytes being compared instead of their values. This meant that negative values were being treated as larger than some positive values. Fixes rust-lang#7829
I broke this script in rust-lang#7502, so that the stable symlink isn't generated anymore. This reverts this change.
…amsteffen Fix FP: no lint when cast is coming from `signum` method call for `cast_possible_truncation` lint Fixes a FP when cast is coming from `signum` method call fixes: rust-lang#5395 changelog: [`cast_possible_truncation`] Fix FP when cast is coming from `signum` method call
Make useless_format recognize format!("")
Closes rust-lang#7796
changelog: [`useless_format`] Fix for false negitive for `format!("")`
Fix deploy script I broke this script in rust-lang#7502, so that the stable symlink isn't generated anymore. This reverts this change. changelog: none
missing_safety_doc: Handle 'implementation safety' headers as well We hit some FPs on this in `yoke`, it's somewhat normal to mark trait impl safety with "implementation safety". We could also broaden the check for headers which contain the word "safety" somehow, or split out impl safety stuff to only apply to traits. changelog: handle 'implementation safety' headers in `missing_safety_doc`
…vidtwco Don't mark for loop iter expression as desugared We typically don't mark spans of lowered things as desugared. This helps Clippy rightly discern when code is (not) from expansion. This was discovered by ``@flip1995`` at rust-lang/rust-clippy#7789 (comment).
Properly consider uncased and titlecased characters. Fixes rust-lang#7863.
Fix typo on utils/lib Found some typo when looking through `clippy_utils/src/lib.rs` 🙂 changelog: none
Update rustfmt changelog: none Something changed with `rustup update nightly`
…=flip1995 recommend new branch or deleting branch when synching from rust changelog: none r? `@flip1995` - thanks again for your assistance in zulip earlier, figured I'd take a pass at incorporating your recommendation to delete or use a new branch into the excellent docs here
Update CHANGELOG r? `@xFrednet` (you showed to be a reliable reviewer for this :) ) [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md) changelog: none
Also updated one configuration for nicer formatting
…Frednet Advise to put a :: prefix inside the ticks Fixes rust-lang#7914. changelog: Keep an initial `::` when [`doc_markdown`] suggests to use ticks
…Frednet Add suggestion to missing backticks error changelog: Add a machine applicable suggestion for the [`doc_markdown`] missing backticks lint closes: rust-lang#7737
…r=flip1995 Update Clippy dependencies Clippy has two outdated dependencies, where one indirect dependency has been flagged by rustsec for dropping a lifetime. See [RUSTSEC-2020-0146](https://rustsec.org/advisories/RUSTSEC-2020-0146). This PR updates these dependencies. With previous dependency updates, it was tried to prevent duplicates in the `Cargo.lock` file of rust-lang/rust. I've tried to keep this in mind with this update. * Dependency `semver` * Used in `src/tools/cargo/Cargo.toml` as version `1.0.3` * Used in `src/tools/rust-analyzer/crates/project_model/Cargo.toml` as version `1` * Updated in Clippy from `0.11` to `1.0` (Clippy usually defines the major and minor patch version). The `Cargo.lock` file lists `1.0.3` which is one patch version behind the most recent one but prevents a duplicate with cargo's pinned version. * Dependency `cargo_metadata` * Used in several tools as `0.14` * Used in `src/tools/tidy` and `src/tools/rls` as `0.12` * Updated in Clippy from `0.12` to `0.14` All updates to the `Cargo.lock` have been done automatically by `x.py`. There are still some tools with these outdated dependencies. Clippy didn't require any changes, and it would be likely that the others could also be updated without any problem. Let me know if I should try to update them as well 🙃. Keep up the good work, whoever is reading this 🦀 --- For Clippy: changelog: none
lower_case in span_lint_and_help document changelog: none
Rustup r? `@ghost` changelog: none
|
Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 4e5319b has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
|
☀️ Test successful - checks-actions |
This was referenced Nov 4, 2021
|
Finished benchmarking commit (4961b10): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth