Make --include and --exclude use exact matching.
#1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
exact-include-exclude
branch
from
5d31d14
to
508e0d8
Compare
Currently they do substring matching. But because some benchmarks have a name that is a substring of another it's impossible to match some benchmarks by themselves. E.g.: - Want `webrender`? You'll get `webrender-wrench` too. - Want `syn`? You'll get `deeply-nested-async` too. - Want `deeply-nested`? You'll get `deeply-nested-async` and `deeply-nested-closures` too. This commit makes the matching exact. As a heavy user of these tools I think this is a good trade-off. It makes some things possible that are currently impossible (e.g. including or excluding just `webrender`), at the cost of more typing on occasion, e.g. `--include ctfe-stress-4` instead of `--include ctfe`. (Note: if you specify something that doesn't match any benchmark's name the command will give an error.)
nnethercote
force-pushed
the
exact-include-exclude
branch
from
508e0d8
to
6300a08
Compare
Mark-Simulacrum
approved these changes
Jan 7, 2022
nnethercote
added a commit
to nnethercote/rustc-perf
that referenced
this pull request
Apr 6, 2022
In rust-lang#1138 I changed `--include`/`--exclude` to do exact matching of benchmark names. This was a good idea at the time, but since then we have renamed many benchmarks. There is now no benchmark with a name that is a prefix of another benchmark's name. Also, we now have version numbers in many benchmark names, which are a pain to remember and type. This commit lets you specify a benchmark name by prefix. E.g. `--include=stm` will match `stm32f4-0.14.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently they do substring matching. But because some benchmarks have a
name that is a substring of another it's impossible to match some
benchmarks by themselves. E.g.:
webrender? You'll getwebrender-wrenchtoo.syn? You'll getdeeply-nested-asynctoo.deeply-nested? You'll getdeeply-nested-asyncanddeeply-nested-closurestoo.This commit makes the matching exact. As a heavy user of these tools I
think this is a good trade-off. It makes some things possible that are
currently impossible (e.g. including or excluding just
webrender), atthe cost of more typing on occasion, e.g.
--include ctfe-stress-4instead of
--include ctfe.(Note: if you specify something that doesn't match any benchmark's name
the command will give an error.)