Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --include and --exclude use exact matching. #1138

Merged

Commits on Jan 7, 2022

  1. Make --include and --exclude use exact matching.

    Currently they do substring matching. But because some benchmarks have a
    name that is a substring of another it's impossible to match some
    benchmarks by themselves. E.g.:
    - Want `webrender`? You'll get `webrender-wrench` too.
    - Want `syn`? You'll get `deeply-nested-async` too.
    - Want `deeply-nested`? You'll get `deeply-nested-async` and
      `deeply-nested-closures` too.
    
    This commit makes the matching exact. As a heavy user of these tools I
    think this is a good trade-off. It makes some things possible that are
    currently impossible (e.g. including or excluding just `webrender`), at
    the cost of more typing on occasion, e.g. `--include ctfe-stress-4`
    instead of `--include ctfe`.
    
    (Note: if you specify something that doesn't match any benchmark's name
    the command will give an error.)
    nnethercote committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    6300a08 View commit details
    Browse the repository at this point in the history