Skip to content

Commit

Permalink
Fix desktop and application icons, fixes #5
Browse files Browse the repository at this point in the history
  • Loading branch information
ppacher committed Jul 30, 2020
1 parent 562ec6c commit 5959b1d
Show file tree
Hide file tree
Showing 9 changed files with 90 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/actions/build-deb/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ LABEL maintainer="Patrick Pacher <patrick@safing.io>"


# Installs the `dpkg-buildpackage` command
RUN apt-get update && apt-get install curl build-essential debhelper devscripts equivs -y --no-install-recommends && apt-get clean
RUN apt-get update \
&& apt-get install curl build-essential debhelper devscripts equivs imagemagick -y --no-install-recommends \
&& apt-get clean


# Copies your code file from your action repository to the filesystem path `/` of the container
Expand Down
7 changes: 6 additions & 1 deletion linux/debian/portmaster.install
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@ portmaster_notifier.desktop /etc/xdg/autostart/
portmaster-start /var/lib/portmaster
portmaster.desktop /usr/share/applications/
portmaster_notifier.desktop /usr/share/applications/
portmaster.png /usr/share/pixmaps/
icons/32/portmaster.png /usr/share/pixmaps/
icons/16/portmaster.png /usr/share/icons/hicolor/16x16/apps
icons/32/portmaster.png /usr/share/icons/hicolor/32x32/apps
icons/48/portmaster.png /usr/share/icons/hicolor/48x48/apps
icons/96/portmaster.png /usr/share/icons/hicolor/96x96/apps
icons/128/portmaster.png /usr/share/icons/hicolor/128x128/apps/
2 changes: 2 additions & 0 deletions linux/debian/portmaster.triggers
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
activate update-icon-caches
activate update-desktop-database
1 change: 1 addition & 0 deletions linux/debian/postinst
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ else
print_dl_help "skipped downloading modules!"
fi


# with 0.4.0 portmaster-control has ben renamed to portmaster-start
# and is not placed into /usr/bin anymore.
rm /usr/bin/portmaster-control 2> /dev/null || true
Expand Down
8 changes: 7 additions & 1 deletion linux/debian/rules
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,20 @@
STARTURL ?= https://updates.safing.io/latest/linux_amd64/start/portmaster-start\?CI

# We don't build here, we download the built binaries
build: portmaster-start
build: icons portmaster-start

%:
dh $@ --with=systemd

#portmaster.png:
# convert logo.png -resize 32x32 portmaster.png

icons:
for res in 16 32 48 96 128 ; do \
mkdir -p icons/$$res ; \
convert ./portmaster_logo.png -resize $${res}x$${res} icons/$${res}/portmaster.png ; \
done

portmaster-start:
curl --fail --user-agent GitHub -o portmaster-start $(STARTURL)

Expand Down
2 changes: 1 addition & 1 deletion linux/portmaster.desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
Name=Portmaster
GenericName=Application Firewall
Exec=/var/lib/portmaster/portmaster-start app --data=/var/lib/portmaster
Icon=/usr/share/pixmaps/portmaster.png
Icon=portmaster
Terminal=false
Type=Application
Categories=System
Binary file removed linux/portmaster.png
Binary file not shown.
Binary file added linux/portmaster_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
70 changes: 70 additions & 0 deletions linux/portmaster_logo.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 5959b1d

Please sign in to comment.