Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PM-logo in cinnamon running-application-bar, but in icon in menu #5

Closed
Raskaro opened this issue Jul 6, 2020 · 13 comments · Fixed by #16 · May be fixed by #95
Closed

No PM-logo in cinnamon running-application-bar, but in icon in menu #5

Raskaro opened this issue Jul 6, 2020 · 13 comments · Fixed by #16 · May be fixed by #95
Labels
bug TYPE: a report on something that isn't working linux only ATTRIBUTE: this issue only applies to Linux stale ATTRIBUTE: this issue has not had recent activity

Comments

@Raskaro
Copy link
Contributor

Raskaro commented Jul 6, 2020

While I do have the PM-Logo in the menu, there is no logo in the running-applications-bar (better name for that?) on the bottom.

LM 19.1 Cinnamon-Edition

@ppacher
Copy link
Contributor

ppacher commented Jul 21, 2020

Hi @Raskaro, thanks for reporting that.

I've seen similar issues with cinnamon not playing well with absolute paths in .desktop files. Can you try changing the Icon= line in /usr/share/applications/portmaster.desktop from an absolute path to just portmaster. Should look like:

[Desktop Entry]
Name=Portmaster
GenericName=Application Firewall
Exec=portmaster-control run app --data=/var/lib/portmaster
Icon=portmaster
Terminal=false
Type=Application
Categories=System

@Raskaro
Copy link
Contributor Author

Raskaro commented Jul 22, 2020

Hi!
That doesn't work eighter.

By change I found out that the icon doesn't work on XFCE eighter (the released alpha).

@Raskaro
Copy link
Contributor Author

Raskaro commented Jul 22, 2020

I tried everything from here, clearing the hicolor-cache, various reboots and it still doesn't work. But you are correct, there probably shouldn't be a full path. And probably /usr/share/icons/hicolor/48/apps is a better location (for a 48 px icon).

@ppacher
Copy link
Contributor

ppacher commented Jul 23, 2020

hicolor is the icon theme you installed. We cannot ensure everyone has that theme installed (and should also no mess around in other package content). I'll try to find some time to reproduce this so I can play around on my own.

@ppacher
Copy link
Contributor

ppacher commented Jul 23, 2020

Just another question, how do you usually start the portmaster app?

@ppacher ppacher added linux only ATTRIBUTE: this issue only applies to Linux bug TYPE: a report on something that isn't working labels Jul 28, 2020
@Raskaro
Copy link
Contributor Author

Raskaro commented Jul 28, 2020

hicolor is the icon theme you installed. We cannot ensure everyone has that theme installed (and should also no mess around in other package content). I'll try to find some time to reproduce this so I can play around on my own.

I think we can ... After me searching for fixing the bug, it seems to be the cleanest approach ... https://askubuntu.com/questions/300126/what-is-special-about-the-hicolor-icon-theme

Just another question, how do you usually start the portmaster app?

Using the default Cinnamon-Menu entry - not modified anything there

@ppacher ppacher linked a pull request Jul 30, 2020 that will close this issue
@ppacher
Copy link
Contributor

ppacher commented Jul 30, 2020

@Raskaro thanks for hunting that down. I added the changes you requested in #16. Can you try the .deb installer from the github actions page here. You should have access. Please report back to the PR #16 if it works now.

@ppacher
Copy link
Contributor

ppacher commented Jul 30, 2020

After a lot of try and error I'm more or less confident that this issue has nothing to do with how we package portmaster. It's rather an issue of the compiled portmaster-ui app that does not set the correct X11 WM hint. It seems like a shortcoming with the webview library we are using as there is no way to configure the GTK window icon IMHO. There has been an issue about that in Febuary this year (webview/webview#238) but unfortunately it has been closed by the library author without a comment.

I'll create a dedicated issue in portmaster-ui tomorrow morning and will close this here for now.

ppacher added a commit that referenced this issue Jul 30, 2020
Fix desktop and application icons, fixes #5
@ppacher
Copy link
Contributor

ppacher commented Jul 30, 2020

Re-opened because this bug was not fixed by #16!

@mattkeenan
Copy link
Contributor

This might be related to #93. I have a fix and have a PR. In short I've set up the same list of icon sizes that firefox provides (hopefully this should fix the vast majority of problems).

@dhaavi
Copy link
Member

dhaavi commented Sep 25, 2023

Probably will be fixed by #95.

@dhaavi dhaavi linked a pull request Sep 25, 2023 that will close this issue
Copy link

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Nov 28, 2023
Copy link

github-actions bot commented Dec 5, 2023

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

If the issue has not been resolved, you can find more information in our Wiki or continue the conversation on our Discord.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TYPE: a report on something that isn't working linux only ATTRIBUTE: this issue only applies to Linux stale ATTRIBUTE: this issue has not had recent activity
Projects
None yet
4 participants