Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse dashboard files should allow you to browse facets #428

Closed
awead opened this issue May 13, 2014 · 6 comments
Closed

Browse dashboard files should allow you to browse facets #428

awead opened this issue May 13, 2014 · 6 comments
Assignees
@awead

Comments

@awead
Copy link
Contributor

awead commented May 13, 2014

Test was marked pending by @bmaddy in #426 and needs to be fixed in another PR.
@awead awead self-assigned this May 13, 2014
@awead awead mentioned this issue May 13, 2014
Merged
@awead awead changed the title Fix pending test in browse_dashboard_files_spec.rb Browse dashboard files should allow you to browse facets May 13, 2014
@awead
Copy link
Contributor Author

awead commented May 23, 2014

This appears to be a problem with the modal rendering of the "more" link under facets. When clicking the link, modal appears but without the window. This also occurs in the catalog view and is not related to the new dashboard features.

@jcoyne
Copy link
Contributor

jcoyne commented May 23, 2014

I just fixed this last week in a different project. Here's what I did:

-    <div id="ajax-modal" class="modal hide fade" tabindex="-1"></div>
 +    <%= render 'shared/ajax_modal' %>

@awead
Copy link
Contributor Author

awead commented May 23, 2014

@jcoyne sweet! thanks....

@jcoyne
Copy link
Contributor

jcoyne commented May 23, 2014

I think we need to duplicate this change here:
https://github.com/projecthydra/sufia/blob/fed37f583b94f210e43ec41b58e3e4f8cbc20339/app/views/layouts/sufia-one-column.html.erb#L25

and potentially in the homepage.html.erb

@awead
Copy link
Contributor Author

awead commented May 29, 2014

@mjgiarlo @jcoyne
I'd prefer to hold off on a 4.0.0 release until this issue is fixed. I'm very close... should have it by Monday.

@mjgiarlo
Copy link
Member

👌 @awead

awead added a commit that referenced this issue Jun 2, 2014
@awead
Updating modals and fixing facet features #428
a3ef268
@awead awead mentioned this issue Jun 2, 2014
Merged
awead added a commit that referenced this issue Jun 2, 2014
@awead
Updating modals and fixing facet features #428
fccdc47
awead added a commit that referenced this issue Jun 3, 2014
@awead
Updating modals and fixing facet features #428
3e7bbf2
awead added a commit that referenced this issue Jun 3, 2014
@awead
Updating modals and fixing facet features #428
ac031d1
@awead awead closed this as completed Jun 3, 2014
jcoyne pushed a commit that referenced this issue Nov 17, 2016
@grosscol
Merge pull request #428 from projecthydra-labs/ordered_file_sets_view
33743ec 
Orders file sets in item record.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awead awead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcoyne @mjgiarlo @awead