-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard modals, rspec versions and screen reader #487
Conversation
@@ -16,5 +16,12 @@ def index | |||
super | |||
@selected_tab = :collections | |||
end | |||
|
|||
protected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why this method is protected now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an override from Blacklight::Catalog, in which it is also protected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, OK!
@awead can you rebase this? |
gladly... |
hold on, missed a hash rocket... |
<%= link_to_query(word) -%> | ||
<% end -%> | ||
?</i></h4> | ||
<h4 class="suggest"><em><%= t('blacklight.did_you_mean', :options => safe_join(@response.spelling.words.map { |word| link_to_query(word) }, " #{t('blacklight.or')} ")).html_safe %></em></h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FOUND IT 😉
Dashboard modals, rspec versions and screen reader
WorkShowPresenter should delegate to solr_doc for date fields fixes fixes #487
This addresses three separate issues, #485 #484 and #428