-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in SBMLTransforms::replaceFD
?
#299
Comments
This has now been fixed and merged into development. We plan to have a new release including the fix within the next couple of weeks. |
@fbergmann thanks! Unfortunately while this fixes the failing test case I don't think it is correct in general, e.g. changing the expression from |
I was using
SBMLTransforms::replaceFD
to expand/inline functions in math expressions but ran into incorrect results in some cases:spatial-model-editor/spatial-model-editor#856 (comment)
I think substituting each argument sequentially like this is only valid if there is no overlap between the variables in the function body and the variables that are passed to the function?
The text was updated successfully, but these errors were encountered: