Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for replaceFD issue #299 #300

Merged
merged 6 commits into from
Mar 14, 2023

Conversation

lkeegan
Copy link
Contributor

@lkeegan lkeegan commented Mar 3, 2023

Description

test case for replaceFD issue #299

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

lkeegan and others added 6 commits March 3, 2023 10:08
* libsbml complained about units for the reaction using f_relabelled, so use initial assignment instead

* needed to restore fd ptr
since we have a new function definition the old test failed
@fbergmann fbergmann requested a review from skeating March 10, 2023 14:19
@fbergmann
Copy link
Member

@skeating this is ready to be merged. The documentation test has been cancelled, since it really shouldn't run on Liams repository. But that has nothing to do with this PR.

@fbergmann fbergmann merged commit a2c5e4b into sbmlteam:development Mar 14, 2023
@lkeegan lkeegan mentioned this pull request Mar 14, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants