Formatting code for English nouns and verbs

[SaurabhJamadagni]

Terms

• I have searched open and closed data issues
• I agree to follow Scribe-Data's Code of Conduct

Languages

English

Description

The issue focuses on adding the formatting scripts for nouns and verbs for the English language queried data.

• format_nouns.py
• format_verbs.py

Will tackle the issue in parts. Part of the GSoC project.

[SaurabhJamadagni]

Hey @andrewtavis, could you add the appropriate priority to this issue?

Also, what formatter does Scribe-Data use? autopep8?

[andrewtavis]

Priority applied, @SaurabhJamadagni! And Scribe-Data uses black for formatting :)

[andrewtavis]

For the verbs formatting, @SaurabhJamadagni, the output I got from Wikidata would be for simple present, simple past and past perfect. Unless you really want to keep the model lean as on Wikidata, let’s make the full six conjugations per case in the formatting so the references would be easier. We also don’t need to do six versions of past perfect as this would just be conjugations of have with the past participle as we do for other languages :) :)

[SaurabhJamadagni]

let’s make the full six conjugations per case in the formatting so the references would be easier

Hey @andrewtavis, could you please list the six conjugation cases to include? I am a bit confused 😅

[SaurabhJamadagni]

So would the list be:

presFPS
presSPS
presTPS
presFPP
presSPP
presTPP
pastFPS
pastSPS
pastTPS
pastFPP
pastSPP
pastTPP
pastParticiple

[andrewtavis]

@SaurabhJamadagni, sure thing!

• First person singular
• Second person singular
• Third person singular
• First person plural
• Second person plural
• Third person plural

We’d need the above for present and past, and then for present perfect and past perfect we can just construct it with “have” conjugations: “have run” or “had run”, etc.

[andrewtavis]

So would the list be:

presFPS
presSPS
presTPS
presFPP
presSPP
presTPP
pastFPS
pastSPS
pastTPS
pastFPP
pastSPP
pastTPP
pastParticiple

Exactly, @SaurabhJamadagni!

[SaurabhJamadagni]

Awesome! Got it thanks! On it right now :)

[SaurabhJamadagni]

Hey @andrewtavis, I don't think the verbs_queried.json file shows the updates that were pushed with the new query_verbs.sparql update in the PR #40. How to run the sparql query to update the file? Since it is currently in it's old format, it is difficult to figure out the correct if-else cases.

[andrewtavis]

Ya you’re right, @SaurabhJamadagni 🤦‍♂️ Should have ran it and sent the file. I’ll be home in 20 min and will update it for you!

[andrewtavis]

Got held up, @SaurabhJamadagni. 2836dbb adds the new verbs with all their forms :)

[SaurabhJamadagni]

Awesome @andrewtavis! Thanks :)

[SaurabhJamadagni]

So the values for the key simpPast in the queried verbs, what key in the conjugation does it get assigned too? I mean in these keys:

presFPS
presSPS
presTPS
presFPP
presSPP
presTPP
pastFPS
pastSPS
pastTPS
pastFPP
pastSPP
pastTPP
pastParticiple

[andrewtavis]

I guess all of past ones, so:

pastFPS
pastSPS
pastTPS
pastFPP
pastSPP
pastTPP

Feels a bit weird to do it this way, but then we'd have to change the view. We do that for Russian, but that's explicitly because past tense works differently rather than in the case for English where there just isn't a change. I'd say we're fine to do the 3x2 view for English for now, and we can reevaluate later :)

[SaurabhJamadagni]

So if the following is one of the entries in queried_verbs.json

{
    "infinitive": "dialogue",
    "presFPS": "dialogue",
    "presTPS": "dialogues",
    "simpPast": "dialoged",
    "pastPart": "dialoged"
}

then the formatted file would have:

dialogue: {
"presFPS": "dialogue",
"presSPS": "",
"presTPS": "dialogues",
"presFPP": "",
"presSPP": "",
"presTPP": ""
"pastFPS": "dialoged",
"pastSPS": "dialoged",
"pastTPS": "dialoged",
"pastFPP": "dialoged",
"pastSPP": "dialoged",
"pastTPP": "dialoged",
"pastPart": "dialoged"
}

is this correct @andrewtavis?

[andrewtavis]

We’d also want to apply presFPS to the other present tenses that are currently blank, @SaurabhJamadagni :) Maybe we should switch that to simplePresent in the SPARQL too?

[SaurabhJamadagni]

We’d also want to apply presFPS to the other present tenses that are currently blank

Ohh, so something like this:

"presFPS": "dialogue",
"presSPS": "dialogue",
"presTPS": "dialogues",
"presFPP": "dialogue",
"presSPP": "dialogue",
"presTPP": "dialogue"

But how is "dialogues" third person singular?

[andrewtavis]

I think that dialogue is maybe not the best example @SaurabhJamadagni, but that is the structure we’ll need :) :) “He dialogues the steps in the code”? Seems ok-ish, and other verbs will be fine 😊

[SaurabhJamadagni]

but that is the structure we’ll need :

Ahhh got it!

[andrewtavis]

da6b5c4 finalizes this, @SaurabhJamadagni 😊 Maybe some minor changes will be needed during the next update process, but we can figure it out then :)