-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add English verbs query file #40
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
Look at that CI roll! @SaurabhJamadagni, please review and @wkyoshida can confirm 😊 |
Also, would be great if one of you could do the maintainer checklist 😇🙃 |
This basically means checking off the todos on the checklist that was generated with this PR right? Will do along with the review :) |
That it does! Thank you, @SaurabhJamadagni! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments separating out the sections @andrewtavis. Really helped with the review. Looks great to me! Cool thing ruling out contractions too. That hadn't occurred to me. I hope you had fun with the optionals haha 😄
How to check off the maintainer checklist? I don't see an edit option nor will it keep the checkbox saved when I refresh the page. |
I got the checkboxes for you, @SaurabhJamadagni :) Looks like you two need more rights if it’s not working 🙃 Btw, check Matrix 😉😊 |
?simpPastForm ontolex:representation ?simpPast ; | ||
wikibase:grammaticalFeature wd:Q1392475 ; | ||
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . } | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . } | ||
} . | ||
|
||
# Past Participle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off of what we'd do with the past participle
, i.e. when formatting, to simply use the past participle
to construct the different conjugations for * perfect
tenses..
I can't remember if we discussed the same for the present participle
to construct the different conjugations for * perfect continuous
, e.g. have been walking
. Is that something that we do/will do? Do we need to grab the present participle
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't been doing continuous tenses until now, which is a good thought that maybe we do need this 🤔 I'd argue against present continuous, but maybe there's a use for perfect continuous :) I'm going to merge so we can play around with this a bit more, but have added a note for the weekly 😊
Contributor checklist
Description
This PR includes the query for all English verbs. There are a few points here: