Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English verbs query file #40

Merged
merged 2 commits into from
Aug 20, 2023
Merged

Add English verbs query file #40

merged 2 commits into from
Aug 20, 2023

Conversation

andrewtavis
Copy link
Member

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have updated the CHANGELOG with a description of my changes for the upcoming release (if necessary)

Description

This PR includes the query for all English verbs. There are a few points here:

  • The English verbs model is quite lean as the goal was to not have "unneeded data"
    • We thus don't have forms for all conjugations, but only those that are different
    • In the formatting process we still need to map them to all of them to make sure that the app references don't need to be rewritten for this case
  • "To be" needs to get hard coded within the verbs formatting process as the data structure is dramatically different and adding in all of the conditional selections was getting really annoying
    • Let's discuss if we need to check other irregular verbs
  • Checked by talking about this a bit at CCCamp with one of the main Wikidata Lexeme devs/community members 😊

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis
Copy link
Member Author

Look at that CI roll! @SaurabhJamadagni, please review and @wkyoshida can confirm 😊

@andrewtavis
Copy link
Member Author

Also, would be great if one of you could do the maintainer checklist 😇🙃

@SaurabhJamadagni
Copy link
Collaborator

Also, would be great if one of you could do the #40 (comment) 😇🙃

This basically means checking off the todos on the checklist that was generated with this PR right? Will do along with the review :)

@andrewtavis
Copy link
Member Author

andrewtavis commented Aug 19, 2023

This basically means checking off the todos on the checklist that was generated with this PR right? Will do along with the review :)

That it does! Thank you, @SaurabhJamadagni! 🙏

Copy link
Collaborator

@SaurabhJamadagni SaurabhJamadagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments separating out the sections @andrewtavis. Really helped with the review. Looks great to me! Cool thing ruling out contractions too. That hadn't occurred to me. I hope you had fun with the optionals haha 😄

@SaurabhJamadagni
Copy link
Collaborator

How to check off the maintainer checklist? I don't see an edit option nor will it keep the checkbox saved when I refresh the page.

@andrewtavis
Copy link
Member Author

I got the checkboxes for you, @SaurabhJamadagni :) Looks like you two need more rights if it’s not working 🙃

Btw, check Matrix 😉😊

?simpPastForm ontolex:representation ?simpPast ;
wikibase:grammaticalFeature wd:Q1392475 ;
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . }
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . }
} .

# Past Participle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going off of what we'd do with the past participle, i.e. when formatting, to simply use the past participle to construct the different conjugations for * perfect tenses..

I can't remember if we discussed the same for the present participle to construct the different conjugations for * perfect continuous, e.g. have been walking. Is that something that we do/will do? Do we need to grab the present participle as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't been doing continuous tenses until now, which is a good thought that maybe we do need this 🤔 I'd argue against present continuous, but maybe there's a use for perfect continuous :) I'm going to merge so we can play around with this a bit more, but have added a note for the weekly 😊

@andrewtavis andrewtavis merged commit 0312232 into main Aug 20, 2023
6 checks passed
@andrewtavis andrewtavis deleted the english-verbs branch August 20, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants