-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add English verbs query file #40
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 34 additions & 9 deletions
43
src/scribe_data/extract_transform/English/verbs/query_verbs.sparql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,53 @@ | ||
# All English (Q1860) verbs and the currently implemented tenses for each. | ||
# Enter this query at https://query.wikidata.org/. | ||
|
||
SELECT DISTINCT ?verb ?simplePast ?pastParticiple WHERE { | ||
SELECT DISTINCT ?infinitive ?presFPS ?presTPS ?simpPast ?pastPart WHERE { | ||
# Infinitive (required) | ||
?lexeme a ontolex:LexicalEntry ; | ||
dct:language wd:Q1860 ; | ||
wikibase:lexicalCategory wd:Q24905 ; | ||
wikibase:lemma ?lemma . | ||
wikibase:lemma ?infinitive . | ||
|
||
# Simple Present | ||
OPTIONAL { | ||
?lexeme ontolex:lexicalForm ?presFPSForm . | ||
?presFPSForm ontolex:representation ?presFPS ; | ||
wikibase:grammaticalFeature wd:Q3910936 ; | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q51929074 . } | ||
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . } | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . } | ||
} . | ||
|
||
# Third-person Singular | ||
OPTIONAL { | ||
?lexeme ontolex:lexicalForm ?presTPSForm . | ||
?presTPSForm ontolex:representation ?presTPS ; | ||
wikibase:grammaticalFeature wd:Q51929074 ; | ||
wikibase:grammaticalFeature wd:Q110786 ; | ||
wikibase:grammaticalFeature wd:Q3910936 ; | ||
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . } | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . } | ||
} . | ||
|
||
# Simple Past | ||
OPTIONAL { | ||
?lexeme ontolex:lexicalForm ?simplePastForm . | ||
?simplePastForm ontolex:representation ?simplePast ; | ||
wikibase:grammaticalFeature wd:Q1392475 ; | ||
?lexeme ontolex:lexicalForm ?simpPastForm . | ||
?simpPastForm ontolex:representation ?simpPast ; | ||
wikibase:grammaticalFeature wd:Q1392475 ; | ||
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . } | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . } | ||
} . | ||
|
||
# Past Participle | ||
OPTIONAL { | ||
?lexeme ontolex:lexicalForm ?pastParticipleForm . | ||
?pastParticipleForm ontolex:representation ?pastParticiple ; | ||
wikibase:grammaticalFeature wd:Q1230649 ; | ||
?lexeme ontolex:lexicalForm ?pastPartForm . | ||
?pastPartForm ontolex:representation ?pastPart ; | ||
wikibase:grammaticalFeature wd:Q1230649 ; | ||
FILTER NOT EXISTS { ?presFPSForm wdt:P6191 wd:Q181970 . } | ||
FILTER NOT EXISTS { ?presFPSForm wikibase:grammaticalFeature wd:Q126473 . } | ||
} . | ||
|
||
SERVICE wikibase:label { | ||
bd:serviceParam wikibase:language "[AUTO_LANGUAGE]". | ||
?lemma rdfs:label ?verb . | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off of what we'd do with the
past participle
, i.e. when formatting, to simply use thepast participle
to construct the different conjugations for* perfect
tenses..I can't remember if we discussed the same for the
present participle
to construct the different conjugations for* perfect continuous
, e.g.have been walking
. Is that something that we do/will do? Do we need to grab thepresent participle
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't been doing continuous tenses until now, which is a good thought that maybe we do need this 🤔 I'd argue against present continuous, but maybe there's a use for perfect continuous :) I'm going to merge so we can play around with this a bit more, but have added a note for the weekly 😊