This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Improve Credential Errors #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface is meant to be implemented by credential readers and add more information to credential-related errors. If implemented by a credential reader, every credential parsing, decoding and decrypting error will also include the source of the credential (path to credential file or environment variable name).
This was referenced Nov 11, 2020
Marton6
commented
Nov 11, 2020
SimonBarendse
previously approved these changes
Nov 16, 2020
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
|
Apparently the errors are still not wrapped correctly. For example in case of an invalid credential supplied through the |
SimonBarendse
dismissed
their stale review
Dismissing per request of @Marton6
|
It seems that the issue with errors not being wrapped correctly was related to the CLI code. I implemented the necessary changes in: secrethub/secrethub-cli#358 |
SimonBarendse
approved these changes
Dec 11, 2020
jpcoenen
reviewed
Dec 14, 2020
…key credential This allows setting a passphrase without having to provide a credential itself, which can be used to make configuring the Terraform provider easier.
Add option set set a default passphrase reader
SimonBarendse
approved these changes
Dec 15, 2020
Co-authored-by: Marton Soos <marton.soos@secrethub.io>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SECRETHUB_CREDENTIAL_PASSPHRASEenvironment variable, which is checked if no passphrase reader is provided, but the credential is password-protected