Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Improve Credential Errors #223

Merged
merged 16 commits into from
Dec 15, 2020
Merged

Improve Credential Errors #223

merged 16 commits into from
Dec 15, 2020

Commits on Nov 11, 2020

  1. Add CredentialSource interface and include credential source in errors 

    This interface is meant to be implemented by credential readers and
add more information to credential-related errors. If implemented by
a credential reader, every credential parsing, decoding and decrypting
error will also include the source of the credential (path to credential
file or environment variable name).
    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    65cbf97 View commit details
    Browse the repository at this point in the history

  2. Use credential.FromEnv for reading environment variable

    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    27c7b3d View commit details
    Browse the repository at this point in the history

  3. Prevent credentials.FromEnv from delaying env var read

    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    2bcd529 View commit details
    Browse the repository at this point in the history

  4. Add more detailed no passphrase error

    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    bbe89cb View commit details
    Browse the repository at this point in the history

  5. Check SECRETHUB_CREDENTIAL_PASSPHRASE envvar if no passphrase reader … 

    …is given
    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    4de867f View commit details
    Browse the repository at this point in the history

  6. Run goimports

    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    6c73171 View commit details
    Browse the repository at this point in the history

  7. Make SECRETHUB_CREDENTIAL_PASSPHRASE have priority over passphrase re… 

    …ader
    @Marton6
    Marton6 committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    12e9d3d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Update pkg/secrethub/credentials/key.go 

    Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
    @Marton6 @SimonBarendse
    Marton6 and SimonBarendse committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a86d7da View commit details
    Browse the repository at this point in the history

  2. Refactor err check 

    Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
    @Marton6 @SimonBarendse
    Marton6 and SimonBarendse committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    57d464b View commit details
    Browse the repository at this point in the history

  3. Remove unused import

    @Marton6
    Marton6 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    53bddab View commit details
    Browse the repository at this point in the history

  4. Improve 'Need Passphrase' error 

    Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
    @Marton6 @SimonBarendse
    Marton6 and SimonBarendse committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    48e536f View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Add option set set a default passphrase that is used for the default … 

    …key credential

This allows setting a passphrase without having to provide a credential itself, which can be used to make configuring the Terraform provider easier.
    @jpcoenen
    jpcoenen committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    fd75ad8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #225 from secrethub/feature/default-passphrase-reader 

    Add option set set a default passphrase reader
    @jpcoenen
    jpcoenen committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    e69aa69 View commit details
    Browse the repository at this point in the history

  3. Delay reading of credential from environment variable

    @Marton6
    Marton6 committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    d81fe5a View commit details
    Browse the repository at this point in the history

  4. Wrap errors regarding credential passphrase and specify passphrase so… 

    …urce
    @Marton6
    Marton6 committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    e5f45b9 View commit details
    Browse the repository at this point in the history

  5. fix need passphrase error message 

    Co-authored-by: Marton Soos <marton.soos@secrethub.io>
    @SimonBarendse @Marton6
    SimonBarendse and Marton6 committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    38d7f3b View commit details
    Browse the repository at this point in the history