Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: follow godoc deprecation standards #83

Merged
merged 1 commit into from
Oct 31, 2018
Merged

chore: follow godoc deprecation standards #83

merged 1 commit into from
Oct 31, 2018

Conversation

vaskoz
Copy link
Contributor

@vaskoz vaskoz commented Oct 19, 2018 •
edited

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 19, 2018
extemporalgenome
extemporalgenome approved these changes Oct 22, 2018
View reviewed changes
Copy link

@extemporalgenome extemporalgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaskoz vaskoz mentioned this pull request Oct 25, 2018
Merged
6 tasks
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit e764ae7 into sendgrid:master Oct 31, 2018
@thinkingserious thinkingserious changed the title Follow godoc deprecation standards chore: follow godoc deprecation standards Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extemporalgenome extemporalgenome extemporalgenome approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaskoz @thinkingserious @extemporalgenome