Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing build #65

Merged
merged 4 commits into from Oct 5, 2018
Merged

Conversation

vaskoz
Copy link
Contributor

@vaskoz vaskoz commented Oct 3, 2018

Fixes

The build has been broken for a while due to gometalinter issues. Specifically, these failures.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • gometalinter found errors not being explicitly handled which is bad practice.
  • gometalinter found an optimization where a raw string is better.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
smtpapi.go Outdated Show resolved Hide resolved
@extemporalgenome extemporalgenome added hacktoberfest difficulty: easy fix is easy in difficulty labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 5, 2018
@thinkingserious thinkingserious merged commit 0d9fc28 into sendgrid:master Oct 5, 2018
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@vaskoz
Copy link
Contributor Author

vaskoz commented Oct 25, 2018

Hello @vaskoz,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

Hi @thinkingserious ,

Thanks! I already have a PR that should put me over 5 points here: sendgrid/rest#83

If you could please take a look, I'd really appreciate it. Thanks.

@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

You have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@vaskoz vaskoz deleted the failingBuild branch October 31, 2018 18:07
@thinkingserious thinkingserious changed the title Failing build chore: fix failing build Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants