Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower tolerance of stale blobs on gossip #5935

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Some peers are spamming old blobs from prior to finalization on gossip. We don't ban them quickly enough due to the high-tolerance peer penalty. This PR changes the penalty to a low-tolerance one.

From the peers that I spot-checked, all the spam seemed to be coming from Erigon/Caplin peers. I've communicated this to the Caplin devs, so new releases of Caplin shouldn't have this problem and won't suffer from by being banned by Lighthouse.

I've kept the gossipsub behaviour as Ignore rather than combining with the Reject block above. We are required to Ignore these blobs by the spec: https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/p2p-interface.md#blob-subnets

@michaelsproul michaelsproul added ready-for-review The code is ready for review Networking labels Jun 17, 2024
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelsproul michaelsproul added the v5.2.1 Patch release for v5.2.0 label Jun 18, 2024
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 18, 2024
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jun 18, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jun 19, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5935 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jun 19, 2024

requeue

☑️ This pull request is already queued

@jimmygchen
Copy link
Member

@mergify unqueue

Copy link

mergify bot commented Jun 19, 2024

unqueue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jun 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at adb3f86

mergify bot added a commit that referenced this pull request Jun 19, 2024
@mergify mergify bot merged commit adb3f86 into sigp:unstable Jun 19, 2024
28 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking ready-for-merge This PR is ready to merge. v5.2.1 Patch release for v5.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants