Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all handler events are covered #5945

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

AgeManning
Copy link
Member

Issue Addressed

Logs indicated an RPC message was being dropped when the shutdown timer expired.

I couldn't see any obvious places where this could happen. The catch-all for this should be in the poll_close(). The only case I could think of would be events waiting to be processed in the handler.

This PR handles this edge case by ensuring all events are also handled before the handler is completely terminated.

As it stands, this should capture any currently in-flight messages and all events that are remaining to be processed.

@AgeManning AgeManning added ready-for-review The code is ready for review v5.2.1 Patch release for v5.2.0 labels Jun 18, 2024
@AgeManning
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Jun 19, 2024

queue

🛑 The pull request has been removed from the queue default

Pull request #5945 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@jimmygchen
Copy link
Member

@mergify unqueue

mergify bot added a commit that referenced this pull request Jun 19, 2024
Copy link

mergify bot commented Jun 19, 2024

unqueue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jun 19, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jun 19, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f69ccc3

@mergify mergify bot merged commit f69ccc3 into sigp:unstable Jun 19, 2024
27 of 28 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v5.2.1 Patch release for v5.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants