-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s] Add cluster attributes(autodown, idle-minutes-to-autostop) as annotations to the pod #3870
Open
landscapepainter
wants to merge
23
commits into
skypilot-org:master
Choose a base branch
from
landscapepainter:k8s-add-autodown-annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[k8s] Add cluster attributes(autodown, idle-minutes-to-autostop) as annotations to the pod #3870
landscapepainter
wants to merge
23
commits into
skypilot-org:master
from
landscapepainter:k8s-add-autodown-annotations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landscapepainter
changed the title
[k8s] Add autodown annotations to the pod
[k8s] Add cluster attributes(autodown, idle-minutes-to-autostop) as annotations to the pod
Aug 24, 2024
@romilbhardwaj This is ready for another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @landscapepainter!
Co-authored-by: Romil Bhardwaj <romil.bhardwaj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This resolves #3869
Tested (run the relevant ones):
bash format.sh
sky launch --cloud kubernetes -c mycluster -i 20 --down -y --num-nodes 3 --cpus=1
: confirm if addsAnnotations
to the head/worker pods.sky autostop mycluster --cancel
: confirm if removes theAnnotations
from the head/worker podssky autostop mycluster -i 20 --down
: confirm if adds back theAnnotations
to the head/worker pods.sky launch
with--down
flag only without-i
flag: confirm ifAnnotations
for--down
is added asTrue
andAnnotations
foridle_minutes_to_autostop
is added with value of5
to the pod.sky launch
with-i
flag only without--down
flag: confirm if it fails to run as stopping is not supported for k8s.pytest tests/test_smoke.py --kubernetes -k "not TestStorageWithCredentials"
except the ones that are failing onmaster
branch as well:test_skyserve_fast_update
test_managed_jobs_storage
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh