Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] attestation-name deprecation warning #3072

Closed
ianlewis opened this issue Jan 10, 2024 · 2 comments · Fixed by #3313 or #3456
Closed

[feature] attestation-name deprecation warning #3072

ianlewis opened this issue Jan 10, 2024 · 2 comments · Fixed by #3313 or #3456
Assignees
@kpk47
Labels
area:generic Issue with the generic generator type:feature New feature or request
Milestone
Next release

Comments

@ianlewis
Copy link
Member

ianlewis commented Jan 10, 2024 •
edited
Loading

We should emit a warning if users are using the deprecated attestation-name input.

Related #3031
@ianlewis ianlewis added type:feature New feature or request area:generic Issue with the generic generator labels Jan 10, 2024
@ianlewis ianlewis mentioned this issue Jan 10, 2024
Closed
@laurentsimon laurentsimon added this to the Next release milestone Jan 16, 2024
@kpk47 kpk47 self-assigned this Jan 16, 2024
@kpk47
Copy link
Contributor

kpk47 commented Jan 16, 2024 •
edited
Loading

It looks like you added such a warning in #777.

            if [ "$UNTRUSTED_DEPRECATED_ATTESTATION_NAME" != "" ]; then
              echo "WARNING: deprecated attestation-name was used. Use provenance-name instead."
              untrusted_prov_name="$UNTRUSTED_DEPRECATED_ATTESTATION_NAME"
            fi

And it triggered on the user's Action run: https://github.com/di/id/actions/runs/7184211112/job/19564896850#step:6:242. It looks like we need to make it more visible.

@ianlewis
Copy link
Member Author

I suppose it should be a output as as a warning workflow command so that it's surfaced in the Actions run UI.

@ramonpetgrave64 ramonpetgrave64 mentioned this issue Mar 8, 2024
Merged
7 tasks
@ramonpetgrave64 ramonpetgrave64 mentioned this issue Mar 26, 2024
Merged
5 tasks
laurentsimon pushed a commit that referenced this issue Mar 27, 2024
@ramonpetgrave64
feat(breaking): remove attestation-name input and output (#3456)
2512315 
# Summary

- Reverting #3399
- Fixes
#3031
- Fixes
#3072
- Removes the attestation-name input and output from the
generator_generic_slsa3.yml, which has been deprecated for
provenance-name.

## Testing Process

- We have existing PR Check workflows that do call the generic-genertor
wth the correct parameters
- example-package e2e2 tests have already been updated to use the new
parameter and are already passing.

## Checklist

- [x] Review the contributing [guidelines](./../CONTRIBUTING.md)
- [x] Add a reference to related issues in the PR description.
- [x] Update documentation if applicable.
- [x] Add unit tests if applicable.
- [x] Add changes to the [CHANGELOG](./../CHANGELOG.md) if applicable.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpk47 kpk47

Labels
area:generic Issue with the generic generator type:feature New feature or request
Projects
None yet
Milestone
Next release
3 participants
@ianlewis @kpk47 @laurentsimon