Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attestation-name #777

Merged
merged 14 commits into from
Sep 1, 2022

Conversation

ianlewis
Copy link
Member

@ianlewis ianlewis commented Aug 31, 2022

Fixes #654

generic generator:

  • Refactors predicate-only generation to a separate generate command.
  • Changes default provenance bundle file names to be in line with in-toto attestation bundle file naming conventions
  • Changes the attestation-name input and outputs to provenance-name. The old name can be still used but is deprecated for now.
  • Updated pre-submit tests to use new inputs

container workflow

  • Updated to use the new generate command.

Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis changed the title Rename attestation name Rename attestation-name Aug 31, 2022
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
@ianlewis ianlewis marked this pull request as ready for review August 31, 2022 07:54
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

internal/builders/generic/attest.go Show resolved Hide resolved
internal/builders/generic/attest_test.go Show resolved Hide resolved
internal/testutil/signing.go Show resolved Hide resolved
Signed-off-by: Ian Lewis <ianlewis@google.com>
Signed-off-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Rename attestation.intoto.jsonl to provenance.intoto.jsonl
2 participants