Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update code to handle SLSA v1.0 final when release is cut #546

Closed
asraa opened this issue Mar 27, 2023 · 1 comment
Closed

[chore] Update code to handle SLSA v1.0 final when release is cut #546

asraa opened this issue Mar 27, 2023 · 1 comment
Labels
type:feature New feature request
Milestone
v1.0 support

Comments

@asraa
Copy link
Contributor

asraa commented Mar 27, 2023

This will need to pull through from in-toto
This was referenced Apr 18, 2023
Merged
Closed
@laurentsimon laurentsimon added this to the v1.0 support milestone Apr 20, 2023
@ianlewis ianlewis added the type:feature New feature request label Apr 20, 2023
@ianlewis
Copy link
Member

I believe this is fixed.

ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@naveensrinivasan @ianlewis
Move computesha256 to typescript (slsa-framework#546)
c88f03e 
* Move computesha256 to typescript

- Port the computesha256 from bash to typescript.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Updated to use the native crypto library

- Updated to use the native crypto library
- Included README instructions
- Some minor nits.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Included additional console outputs for debugging

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Removed .prettierrc.json

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Included workflow to validate the computesha256

- Included the workflow to validate the computesha256 github action

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Code review fixes

- Included permissions for the workflow
- Renamed the workflow file
- Updated the input variable to `path`
- Changed the `run` function to non-async
- Updated the README instructions
- Included the tag for pinned SHA

* Updated to npm ci form npm i

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Add new line

* Fix spaces

* Fixed the error in actions code.

* Moved the action within the pre-submit.actions.yml

- Moved the action within the pre-submit.actions.yml
- Removed the redundant instructions in README

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

* Remove extra line

Co-authored-by: Ian Lewis <ianlewis@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature New feature request
Projects
None yet
Milestone
v1.0 support
Development

No branches or pull requests
3 participants
@ianlewis @asraa @laurentsimon