Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support internalParameters #561

Closed
ianlewis opened this issue Apr 17, 2023 · 1 comment · Fixed by #579
Closed

Support internalParameters #561

ianlewis opened this issue Apr 17, 2023 · 1 comment · Fixed by #579
Labels
type:feature New feature request

Comments

@ianlewis
Copy link
Member

systemParameters was renamed to internalParameters in slsa-framework/slsa#817

We need to update the verifier to use the new field name.
@ianlewis ianlewis added the type:feature New feature request label Apr 17, 2023
@ianlewis
Copy link
Member Author

Related #546

This was referenced Apr 21, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@asraa asraa mentioned this issue May 1, 2023
Merged
asraa added a commit to slsa-framework/slsa-github-generator that referenced this issue May 1, 2023
@asraa
chore: update slsa version to v1.0 in docker-based workflow (#2087)
0fa75fd 
Updates the predicate type version string in generate-attestations to
v1.0 for docker-based builder.

This is needed to fix
#1997 as I
update slsa-framework/slsa-verifier#561

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa mentioned this issue May 1, 2023
Merged
laurentsimon pushed a commit to laurentsimon/slsa-github-generator that referenced this issue May 2, 2023
@asraa @laurentsimon
chore: update slsa version to v1.0 in docker-based workflow (slsa-fra…
35d3b39 
…mework#2087)

Updates the predicate type version string in generate-attestations to
v1.0 for docker-based builder.

This is needed to fix
slsa-framework#1997 as I
update slsa-framework/slsa-verifier#561

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa closed this as completed in #579 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update slsa provenance to v1 asraa/slsa-verifier
1 participant
@ianlewis