Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…

…sts coverage (close #334)
snowplow · Sep 15, 2020 · 60af0f9 · 60af0f9 · benjben · Sep 15, 2020
1 parent efac498
commit 60af0f9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/modules/common/src/test/resources/iglu-schemas/schemas/com.test/array/jsonschema/1-0-0 b/modules/common/src/test/resources/iglu-schemas/schemas/com.test/array/jsonschema/1-0-0
@@ -28,6 +28,10 @@
             "type": "string"
           }
         }
+      },
+      "field4": {
+        "type": "string",
+        "maxLength": 64
       }
     },
     "required": ["field"],

diff --git a/...tics.snowplow.enrich.common/enrichments/registry/pii/PiiPseudonymizerEnrichmentSpec.scala b/...tics.snowplow.enrich.common/enrichments/registry/pii/PiiPseudonymizerEnrichmentSpec.scala
@@ -118,7 +118,8 @@ class PiiPseudonymizerEnrichmentSpec extends Specification with ValidatedMatcher
         |      "data": {
         |        "field" : ["hello", "world"],
         |        "field2" : null,
-        |        "field3": null
+        |        "field3": null,
+        |        "field4": ""
         |      }
         |    }
         |  ]
@@ -363,6 +364,11 @@ class PiiPseudonymizerEnrichmentSpec extends Specification with ValidatedMatcher
             fieldMutator = JsonMutators("unstruct_event"),
             schemaCriterion = SchemaCriterion("com.mailgun", "message_clicked", "jsonschema", 1, 0, 0),
             jsonPath = "$.ip"
+          ),
+          PiiJson(
+            fieldMutator = JsonMutators("contexts"),
+            schemaCriterion = SchemaCriterion("com.test", "array", "jsonschema", 1, 0, 0),
+            jsonPath = "$.field4"
           )
         ),
         false,
@@ -447,7 +453,12 @@ class PiiPseudonymizerEnrichmentSpec extends Specification with ValidatedMatcher
             .downField("field3")
             .focus must beSome.like { case json => json.isNull })
 
-        first and second and third
+        // Test that empty string in Pii field gets hashed
+        val fourth = contextJThirdElement
+          .downField("data")
+          .get[String]("field4") must beRight("7a3477dad66e666bd203b834c54b6dfe8b546bdbc5283462ad14052abfb06600")
+
+        first and second and third and fourth
     }
 
     size and validOut