Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: fix PiiPseudonymizerEnrichment for arrays and improve unit tests coverage #334

Closed
benjben opened this issue Sep 7, 2020 · 2 comments
Closed

Common: fix PiiPseudonymizerEnrichment for arrays and improve unit tests coverage #334

benjben opened this issue Sep 7, 2020 · 2 comments
Assignees
@benjben
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@benjben
Copy link
Contributor

benjben commented Sep 7, 2020

When pseudonymizing an array, instead of the individual values each being hashed, the new array becomes {"empty":false,"traversableAgain":true}
@benjben benjben self-assigned this Sep 7, 2020
@chuwy chuwy changed the title Fix PiiPseudonymizerEnrichment for arrays Common: fix PiiPseudonymizerEnrichment for arrays Sep 7, 2020
@chuwy
Copy link
Contributor

chuwy commented Sep 7, 2020

Seems to be a bug?

@chuwy chuwy added the bug Something isn't working label Sep 7, 2020
@benjben
Copy link
Contributor Author

benjben commented Sep 7, 2020

Indeed it is, thanks for the label

@benjben benjben changed the title Common: fix PiiPseudonymizerEnrichment for arrays Common: fix PiiPseudonymizerEnrichment for arrays and improve unit tests coverage Sep 7, 2020
benjben added a commit that referenced this issue Sep 8, 2020
@benjben
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
61f8432 
…sts coverage (close #334)
benjben added a commit that referenced this issue Sep 9, 2020
@benjben
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
cef05f1 
…sts coverage (close #334)
dilyand added a commit that referenced this issue Sep 15, 2020
@dilyand
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
60af0f9 
…sts coverage (close #334)
dilyand added a commit that referenced this issue Sep 15, 2020
@dilyand
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
2f3b421 
…sts coverage (close #334)
dilyand added a commit that referenced this issue Sep 15, 2020
@dilyand
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
6d5e838 
…sts coverage (close #334)
dilyand added a commit that referenced this issue Sep 16, 2020
@dilyand
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
b7e893f 
…sts coverage (close #334)
benjben added a commit that referenced this issue Sep 21, 2020
@benjben
Common: fix PiiPseudonymizerEnrichment for arrays and improve unit te…
5820121 
…sts coverage (close #334)
@chuwy chuwy closed this as completed in 109500a Oct 21, 2020
@chuwy chuwy added this to the 1.4.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjben benjben

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@chuwy @benjben