Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: disable formatting on compile #358

Closed
chuwy opened this issue Sep 18, 2020 · 4 comments
Closed

Common: disable formatting on compile #358

chuwy opened this issue Sep 18, 2020 · 4 comments
Assignees
@chuwy
Labels
under the hood
Milestone
1.4.0

Comments

@chuwy
Copy link
Contributor

chuwy commented Sep 18, 2020 •
edited
Loading

This is recommended practice to check formatting as a CI/CD steps.

Any objections @benjben, @oguzhanunlu? Going to remove it from branch if you have any.
@chuwy chuwy added this to the 1.4.0 milestone Sep 18, 2020
@chuwy chuwy self-assigned this Sep 18, 2020
chuwy added a commit that referenced this issue Sep 18, 2020
@chuwy
Common: disable formatting on compile (close #358)
2b8c98f
@oguzhanunlu
Copy link
Member

I don't have any objections as long as we make sure unformatted code doesn't get merged

@chuwy
Copy link
Contributor Author

chuwy commented Sep 18, 2020

It doesn't: https://github.com/snowplow/enrich/runs/1134317917#step:12:24

@oguzhanunlu
Copy link
Member

That's great @chuwy , I'm in then

@benjben
Copy link
Contributor

benjben commented Sep 19, 2020

I'm in too !

chuwy added a commit that referenced this issue Sep 20, 2020
@chuwy
Common: disable formatting on compile (close #358)
d972e12
chuwy added a commit that referenced this issue Oct 2, 2020
@chuwy
Common: disable formatting on compile (close #358)
19985a9
chuwy added a commit that referenced this issue Oct 6, 2020
@chuwy
Common: disable formatting on compile (close #358)
6980dd9
chuwy added a commit that referenced this issue Oct 6, 2020
@chuwy
Common: disable formatting on compile (close #358)
e683be1
@chuwy chuwy mentioned this issue Oct 6, 2020
Merged
chuwy added a commit that referenced this issue Oct 6, 2020
@chuwy
Common: disable formatting on compile (close #358)
6233d6d
chuwy added a commit that referenced this issue Oct 6, 2020
@chuwy
Common: disable formatting on compile (close #358)
b4bc65a
chuwy added a commit that referenced this issue Oct 6, 2020
@chuwy
Common: disable formatting on compile (close #358)
3bfbff5
@chuwy chuwy mentioned this issue Oct 21, 2020
Closed
@chuwy chuwy closed this as completed in 0c4bd7a Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
under the hood
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
3 participants
@chuwy @oguzhanunlu @benjben