Common: add toThrift and toRaw methods to CollectorPayload (close #345) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure @chuwy ! |
|
Added those and couple of minor bumps to make Snyk completely happy. @oguzhanunlu could you have a look? |
|
It seems CI isn't happy @chuwy , is that expected? |
|
No, not expected - you're right. I added this check in #357 because it can break publishing. Will fix it now. |
chuwy
force-pushed
the
feature/collectorPayload
branch
from
6ecf09e
to
d1bdf5e
Compare
|
Green now, @oguzhanunlu (no idea what those -0.02%). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.