feat: drop node 6 support by no longer testing for it #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
feat/drop-node-6-support
branch
2 times, most recently
from
62775e4
to
7234149
Compare
lili2311
force-pushed
the
feat/drop-node-6-support
branch
from
7234149
to
6f6ec60
Compare
aviadhahami
approved these changes
Mar 12, 2020
| @@ -2,10 +2,9 @@ | |||
| "compilerOptions": { | |||
| "outDir": "./dist", | |||
| "pretty": true, | |||
| "target": "es2015", | |||
| "target": "es2017", | |||
lili2311
force-pushed
the
feat/drop-node-6-support
branch
from
6f6ec60
to
ac783f0
Compare
package.json
Outdated
| @@ -105,11 +105,11 @@ | |||
| "@types/diff": "^3.5.2", | |||
| "@types/lodash": "^4.14.136", | |||
| "@types/needle": "^2.0.4", | |||
| "@types/node": "^6.14.4", | |||
| "@types/node": "13.9.2", | |||
There was a problem hiding this comment.
Not sure you want to bump it to 13.x. Cos this will bring you methods that are available in Node 13. But our lowest support now is Node 8, so preferably this should be 8.10.59
lili2311
force-pushed
the
feat/drop-node-6-support
branch
from
ac783f0
to
98231d9
Compare
lili2311
force-pushed
the
feat/drop-node-6-support
branch
from
98231d9
to
566a54b
Compare
|
🎉 This PR is included in version 1.301.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop supporting Node 6