Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Node 12 support #4793

Merged
merged 1 commit into from
Aug 16, 2023
Merged

chore: drop Node 12 support #4793

merged 1 commit into from
Aug 16, 2023

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Aug 11, 2023 •
edited
Loading

What does this PR do?

This PR updates Nodejs version from 12 to 14.

Any background context you want to provide?

What are the relevant tickets?

HEAD-496

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023 •
edited
Loading

Messages
📖

You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against 9002669

@cat2608 cat2608 force-pushed the chore/HEAD-496-drop-node-12-support branch 6 times, most recently from 07e2da9 to deb6ef9 Compare August 15, 2023 15:27
@cat2608 cat2608 changed the title chore: Drop Nodejs 12 support [HEAD-496] chore: drop Nodejs 12 support [HEAD-496] Aug 16, 2023
@cat2608 cat2608 changed the title chore: drop Nodejs 12 support [HEAD-496] chore: drop Node 12 support [HEAD-496] Aug 16, 2023
@cat2608 cat2608 force-pushed the chore/HEAD-496-drop-node-12-support branch from deb6ef9 to f6da79b Compare August 16, 2023 08:09
@cat2608 cat2608 marked this pull request as ready for review August 16, 2023 08:10
@cat2608 cat2608 requested review from a team as code owners August 16, 2023 08:10
bastiandoetsch
bastiandoetsch approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@bastiandoetsch bastiandoetsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cat2608 cat2608 changed the title chore: drop Node 12 support [HEAD-496] chore: drop Node 12 support Aug 16, 2023
@cat2608 cat2608 force-pushed the chore/HEAD-496-drop-node-12-support branch from f6da79b to 9002669 Compare August 16, 2023 12:33
@cat2608 cat2608 merged commit ae7e3a8 into master Aug 16, 2023
11 checks passed
@cat2608 cat2608 deleted the chore/HEAD-496-drop-node-12-support branch August 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer left review comments

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cat2608 @bastiandoetsch @PeterSchafer