Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Node 12 support #4793

Merged
merged 1 commit into from
Aug 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
matrix:
os: [ubuntu, macos, windows]
snyk_install_method: [binary, npm, yarn, brew]
node_version: [12, 14, 16]
node_version: [14, 16]
exclude:
# Skip yarn for Windows, as it's a bit crazy to get it working in CI environment. Unless we see evidence we need it, I'd avoid it
- snyk_install_method: yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snyk-protect-production-smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu, macos, windows]
node_version: [12, 14, 16]
node_version: [14, 16]
runs-on: ${{ matrix.os }}-latest
steps:
# Avoid modifying line endings in fixtures.
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"snyk": "bin/snyk"
},
"engines": {
"node": ">=12"
"node": ">=14"
},
"workspaces": [
"packages/*"
Expand Down
2 changes: 1 addition & 1 deletion src/cli/runtime.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { gte } from 'semver';

const MIN_RUNTIME = '12.0.0';
const MIN_RUNTIME = '14.0.0';

export const supportedRange = `>= ${MIN_RUNTIME}`;

Expand Down
4 changes: 4 additions & 0 deletions test/jest/unit/runtime.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,8 @@ describe('verify unsupported nodejs runtime versions', () => {
it('verifies v8.0.0 is not supported', async () => {
expect(runtime.isSupported('8.0.0')).toBeFalsy();
});

it('verifies v10.0.0 is not supported', async () => {
expect(runtime.isSupported('10.0.0')).toBeFalsy();
});
});
Loading