Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve messaging for common cloud config and rpc errors #2885

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat: Improve messaging for common cloud config and rpc errors #2885

merged 2 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. feat: Improve messaging for common cloud config and rpc errors 

    1. Add a UnaryClientInterceptor for all gRPC client connections to
catch and rewrite unauthenticated error messages

2. Put the sqlc auth token in the config struct, and add simple validation

3. Add more explanatory error messages in cases where users try to use
cloud features without the proper configuration

4. Prevent sending the SQLC_AUTH_TOKEN env var to plugins

Resolves #2881

Resolves #2881
    @andrewmbenton
    andrewmbenton committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    8750e0d View commit details
    Browse the repository at this point in the history

  2. Don't continue

    @andrewmbenton
    andrewmbenton committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    52b3b25 View commit details
    Browse the repository at this point in the history